Bug 77432 – REGRESSION (r105908): WebKit1.InspectorBarTest is crashing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

To reproduce:

1. run-api-tests

Ever since r105908, WebKit1.InspectorBarTest crashes like this:

Note: Google Test filter = WebKit1.InspectorBarTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from WebKit1
[ RUN      ] WebKit1.InspectorBarTest
2012-01-30 17:57:39.751 TestWebKitAPI[19111:f07] -[WebHTMLView typingAttributes]: unrecognized selector sent to instance 0x7fb95292c9f0
2012-01-30 17:57:39.752 TestWebKitAPI[19111:f07] An uncaught exception was raised
2012-01-30 17:57:39.752 TestWebKitAPI[19111:f07] -[WebHTMLView typingAttributes]: unrecognized selector sent to instance 0x7fb95292c9f0
2012-01-30 17:57:39.754 TestWebKitAPI[19111:f07] (
	0   CoreFoundation                      0x00007fff872c8286 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff93b10d5e objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff873544ce -[NSObject doesNotRecognizeSelector:] + 190
	3   CoreFoundation                      0x00007fff872b5133 ___forwarding___ + 371
	4   CoreFoundation                      0x00007fff872b4f48 _CF_forwarding_prep_0 + 232
	5   TestWebKitAPI                       0x0000000103705501 _ZN13TestWebKitAPI29WebKit1_InspectorBarTest_Test8TestBodyEv + 1617
	6   TestWebKitAPI                       0x000000010370feea _ZN7testing4Test3RunEv + 154
	7   TestWebKitAPI                       0x00000001037109ad _ZN7testing8internal12TestInfoImpl3RunEv + 189
	8   TestWebKitAPI                       0x000000010371129d _ZN7testing8TestCase3RunEv + 205
	9   TestWebKitAPI                       0x00000001037164a9 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 793
	10  TestWebKitAPI                       0x0000000103716189 _ZN7testing8UnitTest3RunEv + 25
	11  TestWebKitAPI                       0x0000000103660f20 _ZN13TestWebKitAPI15TestsController3runEiPPc + 48
	12  TestWebKitAPI                       0x0000000103660d99 main + 121
	13  TestWebKitAPI                       0x0000000103660334 start + 52
	14  ???                                 0x0000000000000002 0x0 + 2
)
2012-01-30 17:57:39.754 TestWebKitAPI[19111:f07] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WebHTMLView typingAttributes]: unrecognized selector sent to instance 0x7fb95292c9f0'
*** First throw call stack:
(
	0   CoreFoundation
                     0x00007fff872c8286 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff93b10d5e objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff873544ce -[NSObject doesNotRecognizeSelector:] + 190
	3   CoreFoundation                      0x00007fff872b5133 ___forwarding___ + 371
	4   CoreFoundation                      0x00007fff872b4f48 _CF_forwarding_prep_0 + 232
	5   TestWebKitAPI                       0x0000000103705501 _ZN13TestWebKitAPI29WebKit1_InspectorBarTest_Test8TestBodyEv + 1617
	6   TestWebKitAPI                       0x000000010370feea _ZN7testing4Test3RunEv + 154
	7   TestWebKitAPI                       0x00000001037109ad _ZN7testing8internal12TestInfoImpl3RunEv + 189
	8   TestWebKitAPI                       0x000000010371129d _ZN7testing8TestCase3RunEv + 205
	9   TestWebKitAPI                       0x00000001037164a9 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 793
	10  TestWebKitAPI                       0x0000000103716189 _ZN7testing8UnitTest3RunEv + 25
	11  TestWebKitAPI                       0x0000000103660f20 _ZN13TestWebKitAPI15TestsController3runEiPPc + 48
	12  TestWebKitAPI                       0x0000000103660d99 main + 121
	13  TestWebKitAPI                       0x0000000103660334 start + 52
	14  ???                                 0x0000000000000002 0x0 + 2
)
terminate called throwing an exception

[Adam Roben (:aroben)]

I think I have a fix.

[Adam Roben (:aroben)]

Before r105908: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/2972
After r105908: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/2973

[Adam Roben (:aroben)]

Created attachment 124724 [details]
Only call -typingAttributes on WebViews, not WebHTMLViews

[WebKit Review Bot]

Attachment 124724 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 124724 [details]
Only call -typingAttributes on WebViews, not WebHTMLViews

r=me

[Adam Roben (:aroben)]

Committed r106359: <http://trac.webkit.org/changeset/106359>