Bug 77385 - flex-pack:center and flex-item-align:center should do true centering
Summary: flex-pack:center and flex-item-align:center should do true centering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2012-01-30 16:47 PST by Ojan Vafai
Modified: 2012-02-10 15:01 PST (History)
2 users (show)

See Also:


Attachments
Patch (13.39 KB, patch)
2012-02-10 12:21 PST, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ojan Vafai 2012-02-10 12:21:33 PST
Created attachment 126552 [details]
Patch
Comment 2 Tony Chang 2012-02-10 12:31:10 PST
Comment on attachment 126552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126552&action=review

If you wanted to be thorough, you could add writing mode tests.

> Source/WebCore/ChangeLog:9
> +        Also, removed passing totalPositiveFlexibility around. We don't
> +        need to know about positive/negative flex once we run the flexing algorithm.

I remember why we had this.  It was when you could flex margins.  Maybe mention that in the ChangeLog.
Comment 3 Ojan Vafai 2012-02-10 15:01:52 PST
Committed r107446: <http://trac.webkit.org/changeset/107446>