Bug 77382 – [Windows] Add API to enable inverted color drawing on a WebView

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Windows] Add API to enable inverted color drawing on a WebView

[Andy Estes]

Created attachment 124630 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 124630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124630&action=review

Can you add pixel tests for this? We should test both the accelerated and non-accelerated cases.

> Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:280
> +void CACFLayerTreeHost::setShouldInvertColors(bool shouldInvertColors)
> +{
> +    UNUSED_PARAM(shouldInvertColors);
> +}

I think it would be clearer to put the parameter name in the header file and omit it here.

[Andy Estes]

Comment on attachment 124630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124630&action=review

>> Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:280
>> +}
> 
> I think it would be clearer to put the parameter name in the header file and omit it here.

I think I'll just omit it from both locations. That seems to be our style for parameter names that add no information.

[Andy Estes]

Created attachment 126694 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 126694 [details]
Patch

I don't think we can check in LayoutTests/platform/win/inverted-colors/non-composited-expected.png, right? It shows inverted drawing, but that won't work until a new WebKitQuartzCoreAdditions has been released.

[Andy Estes]

(In reply to comment #5)
> (From update of attachment 126694 [details])
> I don't think we can check in LayoutTests/platform/win/inverted-colors/non-composited-expected.png, right? It shows inverted drawing, but that won't work until a new WebKitQuartzCoreAdditions has been released.

Since this only tests the non-composited path, which has no dependency on WebKitQuartzCoreAdditions, we can check it in.

[Andy Estes]

Committed r107603: <http://trac.webkit.org/changeset/107603>