Bug 77373 - REGRESSION (r91935): text-combine fails
Summary: REGRESSION (r91935): text-combine fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: mitz
URL: data:text/html,<div style="-webkit-wr...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2012-01-30 15:12 PST by mitz
Modified: 2012-01-30 17:58 PST (History)
0 users

See Also:

Attachments
Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs (3.12 KB, patch)
2012-01-30 17:18 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-01-30 15:12:11 PST 
To reproduce, open the URL. The number 1200 should be rendered horizontally in quarter-width glyphs.
Comment 1 mitz 2012-01-30 15:12:31 PST 
<rdar://problem/10778045>
Comment 2 mitz 2012-01-30 17:18:18 PST 
Created attachment 124636 [details]
Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs
Comment 3 Darin Adler 2012-01-30 17:22:02 PST 
Comment on attachment 124636 [details]
Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs

View in context: https://bugs.webkit.org/attachment.cgi?id=124636&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:68
> +    } else if ((fontData->platformData().widthVariant() != RegularWidth && CTFontGetGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength))
> +        || (fontData->platformData().widthVariant() == RegularWidth && wkGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength))) {

I think this should use ? : or an if statement rather than calling widthVariant twice. Maybe in a helper function.
Comment 4 mitz 2012-01-30 17:58:12 PST 
Fixed in <http://trac.webkit.org/r106310>.