Bug 77368 – [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tony Chang]

I'll upload an pixel result that shows this.  Other platforms don't seem to do this.

[Tony Chang]

Created attachment 124596 [details]
pixel result with scrollbars

In the attach image, the scrollbars shouldn't overflow the green boxes.

[Tony Chang]

dpranke said he's hoping to work on this this quarter.

[Tony Chang]

I tracked this down since I had another ref test fail.

The bug is here: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp#L51

WebRect is defined as a point + width/height.  SkIRect is a left, top, right and bottom edge.  The conversion needs to subtract 1 from the width and the height.

For example, suppose WebRect is at 0, 0 and has a width and height of 10.  This converts to a SkIRect with points at 0, 0, 10, 10, but that's actually a width and height of 11.

This also explains why we don't have right/bottom edges on any of our scrollbars, e.g.:
http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/css1/basic/class_as_selector-expected.png

We'll need to rebaseline many tests, e.g., all textareas and all scrollbars are different.

[Tony Chang]

Created attachment 146351 [details]
Patch

[Tony Chang]

Committed r119748: <http://trac.webkit.org/changeset/119748>

[Kent Tamura]

Probably all of rectangles drawn by the mock theme have this issue.
e.g. LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png