Bug 77360 – [BlackBerry] OS(QNX) also has TM_GMTOFF, TM_ZONE, and TIMEGM

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Yong Li]

OS(QNX) should also define HAVE(TM_GMTOFF, TM_ZONE, and TIMEGM)

[Yong Li]

Created attachment 124585 [details]
the patch

[Rob Buis]

Comment on attachment 124585 [details]
the patch

Looks good.

[WebKit Review Bot]

Comment on attachment 124585 [details]
the patch

Clearing flags on attachment: 124585

Committed r106290: <http://trac.webkit.org/changeset/106290>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Milian Wolff]

can someone clarify how this is supposed to work, or which QNX version should support this?

For QNX6 I can only find timegm in nbutil.h which would also mean we need to link against nbutil.so to get that in.

As-Is the patch that has landed here breaks compilation of QtWebKit for QNX6 for me.

[Yong Li]

(In reply to comment #5)
> can someone clarify how this is supposed to work, or which QNX version should support this?
> 
> For QNX6 I can only find timegm in nbutil.h which would also mean we need to link against nbutil.so to get that in.
> 
> As-Is the patch that has landed here breaks compilation of QtWebKit for QNX6 for me.

TIMEGM isn't important thing. We saw this issue. And it is fixed for playbook 2.x

You can just cherry-pick this patch:

commit 98aacd9c57a8f38261e9fa4554f2cc7e8343030c
Author: Ming Xie <[e-mail]>
Date:   Thu Feb 2 13:50:41 2012 -0500

    2012-02-02  Ming Xie  <[e-mail]>
    
            Disable HAVE_TIMEGM in *GR2.0* build only.
    
            Reviewed by Yong Li.
    
            * wtf/Platform.h:

# ===============================================
#   COMMIT DIFF(S)
# ===============================================

# ===============================================
#   Revision 1: webkit/98aacd9c57a8f38261e9fa4554f2cc7e8343030c
# ===============================================
98aacd9c57a8f38261e9fa4554f2cc7e8343030c
diff --git a/Source/JavaScriptCore/wtf/Platform.h b/Source/JavaScriptCore/wtf/Platform.h
index 2ef394a..f169fbf 100644
--- a/Source/JavaScriptCore/wtf/Platform.h
+++ b/Source/JavaScriptCore/wtf/Platform.h
@@ -673,8 +673,10 @@
     && !OS(ANDROID)
 #define HAVE_TM_GMTOFF 1
 #define HAVE_TM_ZONE 1
+#if !OS(QNX)
 #define HAVE_TIMEGM 1
 #endif
+#endif
 
 #if OS(DARWIN)