Bug 77333 - [chromium] remove exit time destructors from TextureManagerTest
Summary: [chromium] remove exit time destructors from TextureManagerTest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 05:27 PST by jochen
Modified: 2012-01-30 07:24 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.03 KB, patch)
2012-01-30 05:28 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2012-01-30 06:16 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-01-30 05:27:59 PST
[chromium] remove exit time destructors from TextureManagerTest
Comment 1 jochen 2012-01-30 05:28:46 PST
Created attachment 124532 [details]
Patch
Comment 2 Tony Gentilcore 2012-01-30 06:04:14 PST
Comment on attachment 124532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124532&action=review

> Source/WebKit/chromium/ChangeLog:5
> +

Recommend adding another line explaining "why".

> Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h:54
>  \ No newline at end of file

The review tools makes this diff look strange. I assume you just added a newline?
Comment 3 jochen 2012-01-30 06:15:54 PST
(In reply to comment #2)
> (From update of attachment 124532 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124532&action=review
> 
> > Source/WebKit/chromium/ChangeLog:5
> > +
> 
> Recommend adding another line explaining "why".

done

> 
> > Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h:54
> >  \ No newline at end of file
> 
> The review tools makes this diff look strange. I assume you just added a newline?

right, the file had no new line at EOF which triggers a warning in clang (and isn't proper unix format)
Comment 4 jochen 2012-01-30 06:16:51 PST
Created attachment 124540 [details]
Patch
Comment 5 WebKit Review Bot 2012-01-30 07:24:36 PST
Comment on attachment 124540 [details]
Patch

Clearing flags on attachment: 124540

Committed r106243: <http://trac.webkit.org/changeset/106243>
Comment 6 WebKit Review Bot 2012-01-30 07:24:41 PST
All reviewed patches have been landed.  Closing bug.