Bug 77332 - Node::parentOrHostElement(): Node::shadowHost() already returns an Element*
Summary: Node::parentOrHostElement(): Node::shadowHost() already returns an Element*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 05:06 PST by Roland Steiner
Modified: 2012-01-30 07:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2012-01-30 05:08 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2012-01-30 05:06:18 PST 
In Node::parentOrHostElement(), the call to shadowHost() can only return an Element*, or 0. In the former case, the following test is unnecessary, while in the 0 case (if that should ever occur) it would crash.
Comment 1 Roland Steiner 2012-01-30 05:08:17 PST 
Created attachment 124526 [details]
Patch
Comment 2 Kent Tamura 2012-01-30 05:56:27 PST 
Comment on attachment 124526 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-01-30 07:19:19 PST 
Comment on attachment 124526 [details]
Patch

Clearing flags on attachment: 124526

Committed r106242: <http://trac.webkit.org/changeset/106242>
Comment 4 WebKit Review Bot 2012-01-30 07:19:24 PST 
All reviewed patches have been landed.  Closing bug.