Bug 77331 - Web Inspector: should be possible to step through all event listeners when event listener breakpoint is hit
Summary: Web Inspector: should be possible to step through all event listeners when ev...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 04:52 PST by Yury Semikhatsky
Modified: 2012-01-30 23:37 PST (History)
10 users (show)

See Also:

Attachments
Patch (8.59 KB, patch)
2012-01-30 10:23 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (16.79 KB, patch)
2012-01-30 22:54 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-01-30 04:52:42 PST 
Now debugger will only pause in the first listener and stepping out will resume execution.
Comment 1 Yury Semikhatsky 2012-01-30 10:23:38 PST 
Created attachment 124569 [details]
Patch
Comment 2 Yury Semikhatsky 2012-01-30 10:25:54 PST 
(In reply to comment #1)
> Created an attachment (id=124569) [details]
> Patch

I considered moving new instrumentation calls into V8AbstractEventListener/JSEventListener classes in order to have instrumentation only for JS listeners but decided to leave it in EventTarget as it has a single implementation for both engines.
Comment 3 Yury Semikhatsky 2012-01-30 22:54:03 PST 
Created attachment 124676 [details]
Patch
Comment 4 Yury Semikhatsky 2012-01-30 22:57:12 PST 
(In reply to comment #3)
> Created an attachment (id=124676) [details]
> Patch

Same change with a test.
Comment 5 Yury Semikhatsky 2012-01-30 23:37:55 PST 
Committed r106337: <http://trac.webkit.org/changeset/106337>