Bug 77322 - No need to keep anonymous RenderBlock in DETAILS
Summary: No need to keep anonymous RenderBlock in DETAILS
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 76262
  Show dependency treegraph
Reported: 2012-01-30 01:25 PST by Shinya Kawanaka
Modified: 2012-01-30 03:32 PST (History)
1 user (show)

See Also:

Patch (1.76 KB, patch)
2012-01-30 01:42 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-01-30 01:25:05 PST
When detaching children of DETAILS element, anonymous RenderBlock may be left.
It was introduced to prevent crash in r81812, but actually it is not necessary now.

It often keeps unnecessary anonymous RenderObjects, and causes unexpected text diff mismatch when tweaking content element.
Comment 1 Shinya Kawanaka 2012-01-30 01:42:35 PST
Created attachment 124509 [details]
Comment 2 Shinya Kawanaka 2012-01-30 01:45:04 PST
With this patch, Bug 76262's patch will not fail the following tests.

And you can see that this test's expectation has unnecessary RenderBlock (so unexpected text mismatch will occur).

I will fix them in Bug 76262.
Comment 3 Hajime Morrita 2012-01-30 02:08:58 PST
Comment on attachment 124509 [details]

Good catch! Evil is between the lines...
Comment 4 WebKit Review Bot 2012-01-30 03:32:36 PST
Comment on attachment 124509 [details]

Clearing flags on attachment: 124509

Committed r106228: <http://trac.webkit.org/changeset/106228>
Comment 5 WebKit Review Bot 2012-01-30 03:32:40 PST
All reviewed patches have been landed.  Closing bug.