Bug 77298 - ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
Summary: ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
Depends on:
Reported: 2012-01-29 07:58 PST by Steve Faulkner
Modified: 2012-07-11 14:21 PDT (History)
5 users (show)

See Also:

patch (3.74 KB, patch)
2012-07-09 09:31 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Faulkner 2012-01-29 07:58:01 PST
The HTML5 input type=number  element as implemented in webkit includes a spinbutton control which is mapped as 

AXRole:  "AXIncrementor"
 AXSubrole:  "(null)"
 AXRoleDescription:  "stepper"

The ARIA spinbutton role is currently mapped to 
 { "spinbutton", ProgressIndicatorRole }, in webkit

(source: AccessibilityObject.cpp: 1376)

The WAI -ARIA implementation guide maps spinbutton to (source:http://www.w3.org/TR/wai-aria-implementation/#mapping_role_table)
AXRole:  "AXIncrementor"
 AXSubrole:  "(null)"
 AXRoleDescription:  "stepper"

Recommend fixing implementation so it maps to the correct role.
Comment 1 Steve Faulkner 2012-07-08 01:12:01 PDT
I believe changing the current line http://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp#L1402

from { "spinbutton", ProgressIndicatorRole },


 { "spinbutton", IncrementorRole },

would resolve the issue

there may be some changes required in other files for other platforms as in Windows the appropriate mapping would  likely be

{ "spinbutton", SpinButtonRole },
Comment 2 Steve Faulkner 2012-07-08 01:32:01 PDT
Examples of javascript widgets affected by this bug:

in the Ext GWT library the simple form the spin button is identified using ARIA role=spinbutton , it is incorrectly exposed as progress indicator

in the Dojo digit library 
Comment 3 chris fleizach 2012-07-09 09:31:05 PDT
Created attachment 151258 [details]
Comment 4 WebKit Review Bot 2012-07-11 14:21:06 PDT
Comment on attachment 151258 [details]

Clearing flags on attachment: 151258

Committed r122372: <http://trac.webkit.org/changeset/122372>
Comment 5 WebKit Review Bot 2012-07-11 14:21:10 PDT
All reviewed patches have been landed.  Closing bug.