RESOLVED FIXED 77297
[npapi] NPP_GetMIMEDescription should return const char* 
https://bugs.webkit.org/show_bug.cgi?id=77297
Summary [npapi] NPP_GetMIMEDescription should return const char*
vanuan
Reported 2012-01-29 07:41:17 PST
Return type of NPP_GetMIMEDescription was changed from char* to const char*: http://code.google.com/p/npapi-headers/issues/detail?id=2 So it should also be changed in Webkit.
Attachments
patch (1.72 KB, patch)
2012-01-29 13:49 PST, vanuan 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
patch_v2 (4.58 KB, patch)
2012-01-30 13:25 PST, vanuan 		ap: review+
vanuan: commit-queue-
DetailsFormatted DiffDiff
Patch to land (4.85 KB, patch)
2012-02-01 12:55 PST, vanuan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
vanuan
Comment 1 2012-01-29 13:49:07 PST
Created attachment 124469 [details] patch
vanuan
Comment 2 2012-01-29 14:14:14 PST
Can you review, please?
Stuart Morgan
Comment 3 2012-01-30 01:10:43 PST
I'm not a WebKit reviewer, so no.
Alexey Proskuryakov
Comment 4 2012-01-30 10:11:03 PST
Comment on attachment 124469 [details] patch Please also fix references to this in PluginPackage{Qt,Blackberry,Efl}.cpp. They should use NP_GetMIMEDescriptionFuncPtr, not a local typedef.
vanuan
Comment 5 2012-01-30 13:25:22 PST
Created attachment 124587 [details] patch_v2 See updated patch. However, I'm not sure whether all mentioned ports define XP_UNIX. So build can brake. I didn't check all ports, cause I don't have its dependencies installed.
vanuan
Comment 6 2012-01-31 00:21:52 PST
Comment on attachment 124587 [details] patch_v2 View in context: https://bugs.webkit.org/attachment.cgi?id=124587&action=review > Source/WebCore/ChangeLog:11 > + * plugins/npfunctions.h: Seems like I forgot to update the changelog
Alexey Proskuryakov
Comment 7 2012-02-01 12:38:09 PST
Comment on attachment 124587 [details] patch_v2 OK
vanuan
Comment 8 2012-02-01 12:55:02 PST
Created attachment 124997 [details] Patch to land Updated changelog. Patch is ready to land.
WebKit Review Bot
Comment 9 2012-02-01 15:11:17 PST
Comment on attachment 124997 [details] Patch to land Clearing flags on attachment: 124997 Committed r106503: <http://trac.webkit.org/changeset/106503>
WebKit Review Bot
Comment 10 2012-02-01 15:11:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.