Bug 77297 - [npapi] NPP_GetMIMEDescription should return const char*
Summary: [npapi] NPP_GetMIMEDescription should return const char*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77200
  Show dependency tree / graph
 
Reported: 2012-01-29 07:41 PST by vanuan
Modified: 2012-02-01 15:11 PST (History)
4 users (show)

See Also:

Attachments
patch (1.72 KB, patch)
2012-01-29 13:49 PST, vanuan 		ap: review-
ap: commit-queue-
Details | Formatted Diff | Diff
patch_v2 (4.58 KB, patch)
2012-01-30 13:25 PST, vanuan 		ap: review+
vanuan: commit-queue-
Details | Formatted Diff | Diff
Patch to land (4.85 KB, patch)
2012-02-01 12:55 PST, vanuan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vanuan 2012-01-29 07:41:17 PST 
Return type of NPP_GetMIMEDescription was changed from char* to const char*:
http://code.google.com/p/npapi-headers/issues/detail?id=2

So it should also be changed in Webkit.
Comment 1 vanuan 2012-01-29 13:49:07 PST 
Created attachment 124469 [details]
patch
Comment 2 vanuan 2012-01-29 14:14:14 PST 
Can you review, please?
Comment 3 Stuart Morgan 2012-01-30 01:10:43 PST 
I'm not a WebKit reviewer, so no.
Comment 4 Alexey Proskuryakov 2012-01-30 10:11:03 PST 
Comment on attachment 124469 [details]
patch

Please also fix references to this in PluginPackage{Qt,Blackberry,Efl}.cpp. They should use NP_GetMIMEDescriptionFuncPtr, not a local typedef.
Comment 5 vanuan 2012-01-30 13:25:22 PST 
Created attachment 124587 [details]
patch_v2

See updated patch. However, I'm not sure whether all mentioned ports define XP_UNIX. So build can brake. I didn't check all ports, cause I don't have its dependencies installed.
Comment 6 vanuan 2012-01-31 00:21:52 PST 
Comment on attachment 124587 [details]
patch_v2

View in context: https://bugs.webkit.org/attachment.cgi?id=124587&action=review

> Source/WebCore/ChangeLog:11
> +        * plugins/npfunctions.h:

Seems like I forgot to update the changelog
Comment 7 Alexey Proskuryakov 2012-02-01 12:38:09 PST 
Comment on attachment 124587 [details]
patch_v2

OK
Comment 8 vanuan 2012-02-01 12:55:02 PST 
Created attachment 124997 [details]
Patch to land

Updated changelog. Patch is ready to land.
Comment 9 WebKit Review Bot 2012-02-01 15:11:17 PST 
Comment on attachment 124997 [details]
Patch to land

Clearing flags on attachment: 124997

Committed r106503: <http://trac.webkit.org/changeset/106503>
Comment 10 WebKit Review Bot 2012-02-01 15:11:22 PST 
All reviewed patches have been landed.  Closing bug.