Bug 77296 – Make GraphicsContext3DPrivate of GTK port shareable.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[ChangSeok Oh]

I think that GraphicsContext3DPrivate of GTK port could be shareable with another port using glx backend like EFL port.

[ChangSeok Oh]

Created attachment 124464 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 124464 [details]
Patch

We're just moving code here?

[ChangSeok Oh]

(In reply to comment #2)
> (From update of attachment 124464 [details])
> We're just moving code here?

Yes. But in the next patch, I plan to add some codes to support WebGL for EFL port based on this patch.

[Martin Robinson]

Comment on attachment 124464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124464&action=review

> Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h:41
> +    public:
> +    static PassOwnPtr<GraphicsContext3DPrivate> create();
> +    ~GraphicsContext3DPrivate();
> +    bool makeContextCurrent();
> +
> +    private:

Since the code is moving it might be a good idea to fix the indentation of "public:" and "private:"

[ChangSeok Oh]

Created attachment 124490 [details]
Patch

[ChangSeok Oh]

Comment on attachment 124464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124464&action=review

Thank you for review!

>> Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h:41
>> +    private:
> 
> Since the code is moving it might be a good idea to fix the indentation of "public:" and "private:"

Done. :)

[Eric Seidel (no email)]

Comment on attachment 124490 [details]
Patch

rs=me.

[WebKit Review Bot]

Comment on attachment 124490 [details]
Patch

Clearing flags on attachment: 124490

Committed r106220: <http://trac.webkit.org/changeset/106220>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.