Bug 77261 - Remove all references to NSPasteboard objects from the Pasteboard class interface on Mac.
Summary: Remove all references to NSPasteboard objects from the Pasteboard class inter...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on: 77260
Blocks: 77259
  Show dependency tree / graph
 
Reported: 2012-01-27 16:12 PST by Enrica Casucci
Modified: 2012-01-30 08:59 PST (History)
3 users (show)

See Also:

Attachments
patch (15.52 KB, patch)
2012-01-27 16:48 PST, Enrica Casucci 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2012-01-27 16:12:52 PST 
This is a cleanup task required for https://bugs.webkit.org/show_bug.cgi?id=77259.
We want to make sure the only references to NSPasteboard objects are made from within the Pasteboard class only.
Comment 1 Enrica Casucci 2012-01-27 16:48:24 PST 
Created attachment 124401 [details]
patch
Comment 2 WebKit Review Bot 2012-01-27 16:50:14 PST 
Attachment 124401 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/Pasteboard.h:84:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/Pasteboard.h:84:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2012-01-27 16:52:21 PST 
Style issues are fixed.
Comment 4 Enrica Casucci 2012-01-30 08:59:01 PST 
http://trac.webkit.org/changeset/106248