Bug 77253 - [Chromium] Remove references to gyp cygwin build target
Summary: [Chromium] Remove references to gyp cygwin build target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 15:36 PST by Scott Graham
Modified: 2012-01-31 14:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2012-01-27 15:38 PST, Scott Graham 		no flags Details | Formatted Diff | Diff
Patch (3.05 KB, patch)
2012-01-30 16:16 PST, Scott Graham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2012-01-27 15:36:23 PST 
It's no longer necessary, and is set up earlier in the build process.
Comment 1 Scott Graham 2012-01-27 15:38:35 PST 
Created attachment 124385 [details]
Patch
Comment 2 John Abd-El-Malek 2012-01-30 11:27:12 PST 
sweet! (i'm not a reviewer)
Comment 3 WebKit Review Bot 2012-01-30 16:10:08 PST 
Comment on attachment 124385 [details]
Patch

Rejecting attachment 124385 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
nt): Merge conflict in LayoutTests/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 css3/flexbox/cross-axis-scrollbar.html ref test fails on Windows Chromium bots

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/11368712
Comment 4 Scott Graham 2012-01-30 16:16:57 PST 
Created attachment 124622 [details]
Patch
Comment 5 Scott Graham 2012-01-30 16:17:25 PST 
(try rebasing changelogs...)
Comment 6 Julien Chaffraix 2012-01-31 11:12:03 PST 
Comment on attachment 124622 [details]
Patch

Adam reviewed the patch properly, just forwarding his r+ to the rebase.
Comment 7 WebKit Review Bot 2012-01-31 14:00:23 PST 
Comment on attachment 124622 [details]
Patch

Clearing flags on attachment: 124622

Committed r106391: <http://trac.webkit.org/changeset/106391>
Comment 8 WebKit Review Bot 2012-01-31 14:00:28 PST 
All reviewed patches have been landed.  Closing bug.