You need to
before you can comment on or make changes to this bug.
This is a list generated by the GraphicsLayer::fetchTransformOperationList function. The real purpose of this function is to validate the transform operation lists in a keyframe animation. But it also generates a list of the operations themselves. The thing is, this list is already in the keyframes themselves. So it is not really needed and it will make it harder to add support for Filter animations.
Created an attachment (id=124382) [details]
TextureMapper uses fetchTransformOperationList, so it also needs to be changed.
(In reply to comment #1)
> Created an attachment (id=124382) [details] [details]
(From update of attachment 124382 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=124382&action=review
> + static int validateTransformOperations(const KeyframeValueList&, bool& hasBigRotation);
The patch looks fine but I wish the name of this function better explained what its return value was. indexOfOperationsThatMatch() or some such.
Created an attachment (id=124393) [details]
Created an attachment (id=124399) [details]
(In reply to comment #5)
> Created an attachment (id=124399) [details] [details]
TextureMapper changes look good to me!
(From update of attachment 124399 [details])
Attachment 124399 [details] did not pass qt-ews (qt):
Created an attachment (id=124408) [details]
Committed r106190: <http://trac.webkit.org/changeset/106190>
(From update of attachment 124408 [details])
Cleared review? from attachment 124408 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).