Bug 77249 – Get rid of TransformOperationList

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Chris Marrin]

This is a list generated by the GraphicsLayer::fetchTransformOperationList function. The real purpose of this function is to validate the transform operation lists in a keyframe animation. But it also generates a list of the operations themselves. The thing is, this list is already in the keyframes themselves. So it is not really needed and it will make it harder to add support for Filter animations.

[Chris Marrin]

Created attachment 124382 [details]
Patch

[Igor Trindade Oliveira]

TextureMapper uses fetchTransformOperationList, so it also needs to be changed.

(In reply to comment #1)
> Created an attachment (id=124382) [details]
> Patch

Comment on attachment 124382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124382&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:431
> +    static int validateTransformOperations(const KeyframeValueList&, bool& hasBigRotation);

The patch looks fine but I wish the name of this function better explained what its return value was. indexOfOperationsThatMatch() or some such.

[Chris Marrin]

Created attachment 124393 [details]
Patch adding fix for TextureMapper

[Chris Marrin]

Created attachment 124399 [details]
Patch

[Noam Rosenthal]

(In reply to comment #5)
> Created an attachment (id=124399) [details]
> Patch

TextureMapper changes look good to me!

[Early Warning System Bot]

Comment on attachment 124399 [details]
Patch

Attachment 124399 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11359234

[Chris Marrin]

Created attachment 124408 [details]
Patch

[Chris Marrin]

Committed r106190: <http://trac.webkit.org/changeset/106190>

[Eric Seidel (no email)]

Comment on attachment 124408 [details]
Patch

Cleared review? from attachment 124408 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).