Bug 77247 - [chromium] Remove unnecessary retry logic in LayerRendererChromium initialization for accelerated painting
Summary: [chromium] Remove unnecessary retry logic in LayerRendererChromium initializa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 14:39 PST by James Robinson
Modified: 2012-01-30 17:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2012-01-27 14:41 PST, James Robinson 		no flags Details | Formatted Diff | Diff
now with 50% more compilation (3.63 KB, patch)
2012-01-27 15:13 PST, James Robinson 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-01-27 14:39:35 PST 
[chromium] Remove unnecessary retry logic in LayerRendererChromium initialization for accelerated painting
Comment 1 James Robinson 2012-01-27 14:41:09 PST 
Created attachment 124371 [details]
Patch
Comment 2 Adrienne Walker 2012-01-27 14:46:27 PST 
Comment on attachment 124371 [details]
Patch

Looks good to me.  It's kind of awkward to use creation failure as a signal, and I can't see any reason to do that.
Comment 3 WebKit Review Bot 2012-01-27 14:49:20 PST 
Comment on attachment 124371 [details]
Patch

Attachment 124371 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11265858
Comment 4 James Robinson 2012-01-27 14:49:43 PST 
(In reply to comment #3)
> (From update of attachment 124371 [details])
> Attachment 124371 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11265858

Whoops, parenthesis are hard!
Comment 5 James Robinson 2012-01-27 15:13:31 PST 
Created attachment 124379 [details]
now with 50% more compilation
Comment 6 Kenneth Russell 2012-01-30 15:29:42 PST 
Comment on attachment 124379 [details]
now with 50% more compilation

Looks fine to me.
Comment 7 James Robinson 2012-01-30 17:23:24 PST 
Committed r106306: <http://trac.webkit.org/changeset/106306>