WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
77246
Use LayoutSize instead of IntSize for RenderLayer::scrollOffset
https://bugs.webkit.org/show_bug.cgi?id=77246
Summary
Use LayoutSize instead of IntSize for RenderLayer::scrollOffset
Tony Chang
Reported
2012-01-27 14:39:11 PST
Use LayoutSize instead of IntSize for RenderLayer::scrollOffset
Attachments
Patch
(2.56 KB, patch)
2012-01-27 14:40 PST
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2012-01-27 14:40:06 PST
Created
attachment 124370
[details]
Patch
Tony Chang
Comment 2
2012-01-27 14:42:05 PST
In some sense, all of these should be Int{Size,Point} since you can't scroll a fractional unit, but it looks like RenderLayer already uses mostly Layout{Size,Point} everywhere, so this is just for consistency.
Levi Weintraub
Comment 3
2012-01-27 15:09:10 PST
Comment on
attachment 124370
[details]
Patch This LGTM (there are annoying reasons why we want LayoutUnits for scroll), but I'm not a reviewer.
Darin Adler
Comment 4
2012-01-30 10:04:51 PST
Comment on
attachment 124370
[details]
Patch I am not sure this is correct. We intentionally don’t use rendering coordinates for scrolling; this is the place that the fractional layout machinery meets the non-fractional scrolling so some conversion is necessary. We should get the folks working on fractional pixel layout to remind us about how this works.
Tony Chang
Comment 5
2012-01-30 10:44:48 PST
(In reply to
comment #4
)
> (From update of
attachment 124370
[details]
) > I am not sure this is correct. We intentionally don’t use rendering coordinates for scrolling; this is the place that the fractional layout machinery meets the non-fractional scrolling so some conversion is necessary. We should get the folks working on fractional pixel layout to remind us about how this works.
Levi is working on fractional pixel layout. Maybe he can explain in more detail why we use LayoutUnits for scroll offsets.
Levi Weintraub
Comment 6
2012-02-07 14:42:18 PST
(In reply to
comment #5
)
> Levi is working on fractional pixel layout. Maybe he can explain in more detail why we use LayoutUnits for scroll offsets.
My initial response was incorrect. In the correct version of our patch, which we're working to get committed now, all scroll values are stored as integers representing pixels. We're working to correct this fallacy in trunk. Sorry for the confusion.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug