Bug 77244 - [JSC] ThunkGenerators.cpp should hide its asm-defined symbols
Summary: [JSC] ThunkGenerators.cpp should hide its asm-defined symbols
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 72854
  Show dependency treegraph
 
Reported: 2012-01-27 14:15 PST by Hajime Morrita
Modified: 2012-01-27 15:28 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.25 KB, patch)
2012-01-27 14:30 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-01-27 14:15:14 PST
This is a followup for Bug 77150.
ThunkGenerators.cpp also defines some thunks that should be hidden.
Comment 1 Hajime Morrita 2012-01-27 14:30:13 PST
Created attachment 124369 [details]
Patch
Comment 2 Hajime Morrita 2012-01-27 14:33:21 PST
Hi Filip, would you mind taking a look at this small imitation?
This is a followup of Bug 77150 to hide some more asm-made symbols.
Comment 3 Filip Pizlo 2012-01-27 14:36:15 PST
Comment on attachment 124369 [details]
Patch

I buy it.  R=me.
Comment 4 Hajime Morrita 2012-01-27 14:58:57 PST
Comment on attachment 124369 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-01-27 15:28:33 PST
Comment on attachment 124369 [details]
Patch

Clearing flags on attachment: 124369

Committed r106161: <http://trac.webkit.org/changeset/106161>
Comment 6 WebKit Review Bot 2012-01-27 15:28:38 PST
All reviewed patches have been landed.  Closing bug.