Bug 77243 - [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
Summary: [chromium] Add support for building standalone webkit/chromium checkouts with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on: 77287
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-27 14:12 PST by Nico Weber
Modified: 2012-01-28 15:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.73 KB, patch)
2012-01-27 14:13 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (6.42 KB, patch)
2012-01-27 17:51 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (6.42 KB, patch)
2012-01-27 18:10 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-01-27 14:12:45 PST 
[chromium] Add support for building standalone webkit/chromium checkouts with ninja.
Comment 1 Nico Weber 2012-01-27 14:13:03 PST 
Created attachment 124367 [details]
Patch
Comment 2 Nico Weber 2012-01-27 14:14:16 PST 
Comment on attachment 124367 [details]
Patch

This will probably do it, but it looks like nobody ever used ninja/linux with standalone webkit builds yet -- the ninja gyp generator can't handle this configuration yet. I'm looking into that.
Comment 3 Nico Weber 2012-01-27 17:51:50 PST 
Created attachment 124410 [details]
Patch
Comment 4 Nico Weber 2012-01-27 17:52:13 PST 
Depends on http://codereview.chromium.org/9298039/
Comment 5 Nico Weber 2012-01-27 18:10:38 PST 
Created attachment 124413 [details]
Patch
Comment 6 Adam Barth 2012-01-28 00:14:24 PST 
Thanks!  Please feel free to land whenever everything else is in place.
Comment 7 Nico Weber 2012-01-28 14:21:22 PST 
Landing should be safe now (modulo possible breakages I might have introduced), but it needs the chromium deps roll in bug 77287 to actually work.

Once that's in

  Tools/Scripts/update-webkit --chromium --ninja
  Tools/Scripts/build-webkit --chromium

should do the trick. I only ran that a single time and verified that the build doesn't fail, and didn't do any testing. Let me know how it goes!
Comment 8 WebKit Review Bot 2012-01-28 15:43:47 PST 
Comment on attachment 124413 [details]
Patch

Clearing flags on attachment: 124413

Committed r106195: <http://trac.webkit.org/changeset/106195>
Comment 9 WebKit Review Bot 2012-01-28 15:43:52 PST 
All reviewed patches have been landed.  Closing bug.