Bug 77241 - The cpp parser of prepare-ChangeLog treats if(...) {} as a method
Summary: The cpp parser of prepare-ChangeLog treats if(...) {} as a method
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 13:49 PST by Kentaro Hara
Modified: 2013-01-07 07:02 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.16 KB, patch)
2012-01-27 13:55 PST, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
rebased patch for commit (5.16 KB, patch)
2012-01-27 20:52 PST, Kentaro Hara
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
rebased patch for commit (5.38 KB, patch)
2012-01-27 21:06 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for commit (5.13 KB, patch)
2012-01-27 21:17 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-27 13:49:56 PST
The cpp parser of prepare-ChangeLog is wrong, and an inner {} block in a method is treated as a method. Accurately, an inner {} block in a method in some namespace or class is treated as a method.

class C {
    void func()
    {
        if (1) {    // This is treated as a method.
        }
    }
};
Comment 1 Kentaro Hara 2012-01-27 13:55:44 PST
Created attachment 124362 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-27 19:11:31 PST
Comment on attachment 124362 [details]
Patch

Rejecting attachment 124362 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
epare-ChangeLog
patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt
patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp
Hunk #1 FAILED at 303.
1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1

Full output: http://queues.webkit.org/results/11191949
Comment 3 Kentaro Hara 2012-01-27 20:52:05 PST
Created attachment 124426 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2012-01-27 20:55:51 PST
Comment on attachment 124426 [details]
rebased patch for commit

Rejecting attachment 124426 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:

patching file Tools/Scripts/prepare-ChangeLog
patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt
patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp
Hunk #1 FAILED at 303.
1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/11358409
Comment 5 WebKit Review Bot 2012-01-27 21:02:45 PST
Comment on attachment 124426 [details]
rebased patch for commit

Rejecting attachment 124426 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:

patching file Tools/Scripts/prepare-ChangeLog
patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt
patching file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp
Hunk #1 FAILED at 303.
1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/11191975
Comment 6 Kentaro Hara 2012-01-27 21:06:36 PST
Created attachment 124427 [details]
rebased patch for commit
Comment 7 Kentaro Hara 2012-01-27 21:17:28 PST
Created attachment 124428 [details]
rebased patch for commit
Comment 8 WebKit Review Bot 2012-01-27 22:24:37 PST
Comment on attachment 124428 [details]
rebased patch for commit

Clearing flags on attachment: 124428

Committed r106183: <http://trac.webkit.org/changeset/106183>