Landing the test disabled, since it's failing on Chromium's EWS (cr-linux) for unknown reasons (it passes locally in DRT and Chromium builds on Linux)
The test output includes stringified Date objects, and even though an absolute time is used the default string output includes the time zone: -value is: Sun Feb 09 1653 22:13:20 GMT-0800 (PST) (type: object) -store.put(value, 'key') -store.get('key') -String(result): Sun Feb 09 1653 22:13:20 GMT-0800 (PST) +value is: Sun Feb 09 1653 22:13:20 GMT-0800 (Pacific Standard Time) (type: object) +store.put(value, 'key') +store.get('key') +String(result): Sun Feb 09 1653 22:13:20 GMT-0800 (Pacific Standard Time) Note "PST" vs "Pacific Standard Time". Wheee. Since the "value is: ..." and "String(result): ..." lines are just for debugging I can elide that or make it emit the JSON serialization.
Created attachment 124792 [details] Patch
Attachment 124792 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource From git://git.webkit.org/WebKit 0d303ad..e0cd0a9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 106377 = 0d303add2919f49b485767126a3a9ddd6d40b7cf r106378 = 97559abe1ce4b92d73df9d0c773b10bea57d1a0d r106379 = e0cd0a9a94b1530747c0cba1599d65f2470df1f8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Auto-merging Source/WebCore/WebCore.exp.in Auto-merging Source/WebKit/mac/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit/mac/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 124792 [details] Patch Seems fine. You could possibly also do something like Date.prototype.toString = function() { return Date.UTC(this.getUTCFullYear(), this.getUTCMonth(), this.getUTCDay(), ...); } to get controllable results.
(In reply to comment #4) > (From update of attachment 124792 [details]) > Seems fine. You could possibly also do something like Date.prototype.toString = function() { > return Date.UTC(this.getUTCFullYear(), this.getUTCMonth(), this.getUTCDay(), ...); > } > to get controllable results. Yeah, I considered that (or ... = Date.prototype.toGMTString, or ... = Date.prototype.toJSON) but it wasn't adding much value to the test.
Comment on attachment 124792 [details] Patch Clearing flags on attachment: 124792 Committed r106405: <http://trac.webkit.org/changeset/106405>
All reviewed patches have been landed. Closing bug.