Bug 77233 – Add ElementAttributeData class to replace internal uses of NamedNodeMap

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Caio Marcelo de Oliveira Filho]

Add ElementAttributeData class to replace internal uses of NamedNodeMap

[Caio Marcelo de Oliveira Filho]

Created attachment 124344 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Created attachment 124364 [details]
Patch

[Alexis Menard (darktears)]

(In reply to comment #2)
> Created an attachment (id=124364) [details]
> Patch

To fix the win problem you need to add your file in CSSAllInOne.cpp.

[Caio Marcelo de Oliveira Filho]

(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=124364) [details] [details]
> > Patch
> 
> To fix the win problem you need to add your file in CSSAllInOne.cpp.

Thanks! I think that's it. But in my case I think is dom/DOMAllInOne.cpp. I'm uploading a rebase version to check ;-)

[Caio Marcelo de Oliveira Filho]

Created attachment 124576 [details]
Patch

[Andreas Kling]

Comment on attachment 124576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124576&action=review

r=me, looks like a good place to start. Mac build needs fixing though.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:737
> +		2CF6878A14D32EFF00340F39 /* ElementAttributeData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2CF6878914D32EFF00340F39 /* ElementAttributeData.h */; };

Needs "settings = {ATTRIBUTES = (Private, ); };"

[Caio Marcelo de Oliveira Filho]

Created attachment 124657 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 124657 [details]
Patch for landing

Clearing flags on attachment: 124657

Committed r106323: <http://trac.webkit.org/changeset/106323>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.