RESOLVED FIXED 77233
Add ElementAttributeData class to replace internal uses of NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=77233
Summary Add ElementAttributeData class to replace internal uses of NamedNodeMap
Caio Marcelo de Oliveira Filho
Reported 2012-01-27 11:37:07 PST
Add ElementAttributeData class to replace internal uses of NamedNodeMap
Attachments
Patch (24.70 KB, patch)
2012-01-27 11:55 PST, Caio Marcelo de Oliveira Filho
no flags
Patch (27.44 KB, patch)
2012-01-27 13:56 PST, Caio Marcelo de Oliveira Filho
no flags
Patch (20.98 KB, patch)
2012-01-30 12:01 PST, Caio Marcelo de Oliveira Filho
no flags
Patch for landing (21.02 KB, patch)
2012-01-30 18:48 PST, Caio Marcelo de Oliveira Filho
no flags
Caio Marcelo de Oliveira Filho
Comment 1 2012-01-27 11:55:41 PST
Caio Marcelo de Oliveira Filho
Comment 2 2012-01-27 13:56:08 PST
Alexis Menard (darktears)
Comment 3 2012-01-30 09:11:07 PST
(In reply to comment #2) > Created an attachment (id=124364) [details] > Patch To fix the win problem you need to add your file in CSSAllInOne.cpp.
Caio Marcelo de Oliveira Filho
Comment 4 2012-01-30 11:44:40 PST
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=124364) [details] [details] > > Patch > > To fix the win problem you need to add your file in CSSAllInOne.cpp. Thanks! I think that's it. But in my case I think is dom/DOMAllInOne.cpp. I'm uploading a rebase version to check ;-)
Caio Marcelo de Oliveira Filho
Comment 5 2012-01-30 12:01:37 PST
Andreas Kling
Comment 6 2012-01-30 15:31:42 PST
Comment on attachment 124576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124576&action=review r=me, looks like a good place to start. Mac build needs fixing though. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:737 > + 2CF6878A14D32EFF00340F39 /* ElementAttributeData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2CF6878914D32EFF00340F39 /* ElementAttributeData.h */; }; Needs "settings = {ATTRIBUTES = (Private, ); };"
Caio Marcelo de Oliveira Filho
Comment 7 2012-01-30 18:48:15 PST
Created attachment 124657 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-01-30 19:53:56 PST
Comment on attachment 124657 [details] Patch for landing Clearing flags on attachment: 124657 Committed r106323: <http://trac.webkit.org/changeset/106323>
WebKit Review Bot
Comment 9 2012-01-30 19:54:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.