RESOLVED FIXED 77231
HTMLPreloadScanner should understand the <base> element 
https://bugs.webkit.org/show_bug.cgi?id=77231
Summary HTMLPreloadScanner should understand the <base> element
WebKit Review Bot
Reported 2012-01-27 11:00:50 PST
HTMLPreloadScanner should understand the <base> element Requested by abarth_ on #webkit.
Attachments
sketch (not working) (4.62 KB, patch)
2012-01-27 17:41 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (15.22 KB, patch)
2012-01-31 16:45 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.21 KB, patch)
2012-01-31 18:03 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-27 17:41:28 PST
Created attachment 124407 [details] sketch (not working)
Adam Barth
Comment 2 2012-01-31 16:45:25 PST
Created attachment 124848 [details] Patch
Eric Seidel (no email)
Comment 3 2012-01-31 17:35:35 PST
Comment on attachment 124848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124848&action=review LGTM. > Source/WebCore/ChangeLog:9 > + preloadnig resources. If there was a <base> tag, this could cause the ah preloadnig! > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:219 > + // The first baseElementURL is the one that counts. You probably want to say the first <base> element wins.
Adam Barth
Comment 4 2012-01-31 18:03:59 PST
Created attachment 124863 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-31 20:08:10 PST
Comment on attachment 124863 [details] Patch for landing Clearing flags on attachment: 124863 Committed r106426: <http://trac.webkit.org/changeset/106426>
WebKit Review Bot
Comment 6 2012-01-31 20:08:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.