Bug 77231 - HTMLPreloadScanner should understand the <base> element
Summary: HTMLPreloadScanner should understand the <base> element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 11:00 PST by WebKit Review Bot
Modified: 2012-01-31 20:08 PST (History)
4 users (show)

See Also:

Attachments
sketch (not working) (4.62 KB, patch)
2012-01-27 17:41 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (15.22 KB, patch)
2012-01-31 16:45 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (15.21 KB, patch)
2012-01-31 18:03 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-01-27 11:00:50 PST 
HTMLPreloadScanner should understand the <base> element
Requested by abarth_ on #webkit.
Comment 1 Adam Barth 2012-01-27 17:41:28 PST 
Created attachment 124407 [details]
sketch (not working)
Comment 2 Adam Barth 2012-01-31 16:45:25 PST 
Created attachment 124848 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-01-31 17:35:35 PST 
Comment on attachment 124848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124848&action=review

LGTM.

> Source/WebCore/ChangeLog:9
> +        preloadnig resources.  If there was a <base> tag, this could cause the

ah preloadnig!

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:219
> +    // The first baseElementURL is the one that counts.

You probably want to say the first <base> element wins.
Comment 4 Adam Barth 2012-01-31 18:03:59 PST 
Created attachment 124863 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-31 20:08:10 PST 
Comment on attachment 124863 [details]
Patch for landing

Clearing flags on attachment: 124863

Committed r106426: <http://trac.webkit.org/changeset/106426>
Comment 6 WebKit Review Bot 2012-01-31 20:08:15 PST 
All reviewed patches have been landed.  Closing bug.