Bug 77197 – [GTK] Handle printing errors in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Printing errors should be sent from the web process to the ui process in the callback used by DrawPagesForPrinting message.

[Carlos Garcia Campos]

Created attachment 127987 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gustavo Noronha (kov)]

Comment on attachment 127987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127987&action=review

OK, looks good to me!

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:112
> + * @WEBKIT_PRINT_ERROR_INVALID_PAGE_RANGE: There are no pages to print

Nit: Invalid page ranges could include pages that exist, so perhaps saying there are no pages is not the most conceptually correct here. Go for Invalid page range?

> Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:207
> +     * finishes after an error and #WebKitPrintOperation::finished signal is emitted
> +     * after this one.

Suggestion: replace the last sentence with just The #WebKitPrintOperation::finished signal is emitted after this one.

> Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp:102
> +        if (strcmp(gtk_printer_get_name(printer), "Print to File"))

Hrm. Something just popped on my mind. Does gtk_printer_get_name() return the localized string? I guess all of us run our systems in English, but be good to make this robust.

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 127987 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127987&action=review
> 
> OK, looks good to me!

Thanks for reviewing it!

> > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:112
> > + * @WEBKIT_PRINT_ERROR_INVALID_PAGE_RANGE: There are no pages to print
> 
> Nit: Invalid page ranges could include pages that exist, so perhaps saying there are no pages is not the most conceptually correct here. Go for Invalid page range?

Invalid page range sounds good to me.

> > Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:207
> > +     * finishes after an error and #WebKitPrintOperation::finished signal is emitted
> > +     * after this one.
> 
> Suggestion: replace the last sentence with just The #WebKitPrintOperation::finished signal is emitted after this one.

Ok.

> > Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp:102
> > +        if (strcmp(gtk_printer_get_name(printer), "Print to File"))
> 
> Hrm. Something just popped on my mind. Does gtk_printer_get_name() return the localized string? I guess all of us run our systems in English, but be good to make this robust.

Yes, it returned the localized string, but gtk_test_init() resets the locale to C for that reason, making sure unit tests always run with the C locale. My system locale is ES indeed, and test work without problems :-)

[Carlos Garcia Campos]

Committed r110714: <http://trac.webkit.org/changeset/110714>