Bug 77186 - [Chromium] REGRESSION(r87067): WebFrame::setFindEndstateFocusAndSelection() doesn't set the selection for <input> and <textarea>
Summary: [Chromium] REGRESSION(r87067): WebFrame::setFindEndstateFocusAndSelection() d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P1 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 22:15 PST by Kent Tamura
Modified: 2012-01-30 01:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2012-01-26 22:31 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Kent Tamura 2012-01-26 22:31:52 PST 
Created attachment 124265 [details]
Patch
Comment 2 Hajime Morrita 2012-01-29 20:04:31 PST 
Comment on attachment 124265 [details]
Patch

Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check.
Comment 3 Kent Tamura 2012-01-29 20:13:41 PST 
(In reply to comment #2)
> Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check.

How about changing it to "if (host->isFocusable())" ?  Does it make sense for non-builtin shadow DOM components?
Comment 4 Hayato Ito 2012-01-29 21:29:28 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check.
> 
> How about changing it to "if (host->isFocusable())" ?  Does it make sense for non-builtin shadow DOM components?

I don't think it make sense for non-buitin shadow DOM components. I cannot see a clear reason to return host instead of an internal focusable element in case of non-builtin shadow DOM components.
Comment 5 Kent Tamura 2012-01-29 21:36:19 PST 
ok, I'm landing the patch as is for now.
Comment 6 WebKit Review Bot 2012-01-29 23:23:15 PST 
Comment on attachment 124265 [details]
Patch

Clearing flags on attachment: 124265

Committed r106216: <http://trac.webkit.org/changeset/106216>