Bug 77175 – Import Chromium's dom_perf test

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

Chromium perf bots run dom_perf tests internally developed at Google. However, this test suite hasn't been publicly available despite the fact it has caught a number of webcore regressions. We should import it to WebKit to be ran by run-perf-test.

[Ryosuke Niwa]

Created attachment 124266 [details]
Adds dom_perf

[Adam Barth]

Comment on attachment 124266 [details]
Adds dom_perf

View in context: https://bugs.webkit.org/attachment.cgi?id=124266&action=review

Is this the canonical version of this perf test?  If not, should we add a README file explaining where to find the canonical version?

> PerformanceTests/ChangeLog:13
> +        * ChromiumDOMPerf: Added.

Can we just call it DOMPerf?

[Ryosuke Niwa]

(In reply to comment #2)
> (From update of attachment 124266 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124266&action=review
> 
> Is this the canonical version of this perf test?  If not, should we add a README file explaining where to find the canonical version?

By "canonical", do you mean the original version? There's a copy of this benchmark in Google's internal repository but we can't really point to that since it's not publicly available. ChromiumDOMPerf/resources/dom is an exact copy of the original benchmark (except indentation styles and some minor nits).

I don't think anyone's working to make the rest of test suite publicly available and I don't plan to.

>> PerformanceTests/ChangeLog:13
>> +        * ChromiumDOMPerf: Added.
> 
> Can we just call it DOMPerf?

I want to keep this name to differentiate it from other DOM perf tests will be adding.\

[Adam Barth]

> By "canonical", do you mean the original version? There's a copy of this benchmark in Google's internal repository but we can't really point to that since it's not publicly available. ChromiumDOMPerf/resources/dom is an exact copy of the original benchmark (except indentation styles and some minor nits).
> 
> I don't think anyone's working to make the rest of test suite publicly available and I don't plan to.

Ok.

> >> PerformanceTests/ChangeLog:13
> >> +        * ChromiumDOMPerf: Added.
> > 
> > Can we just call it DOMPerf?
> 
> I want to keep this name to differentiate it from other DOM perf tests will be adding.\

Maybe we should give it a snappier name then?  Maybe something like DOMSpider ?  Calling it ChromiumDOMPerf seems to imply that it belongs to Chromium, which isn't really right.  It belongs to the WebKit community (or perhaps the open source community at large).

[Ryosuke Niwa]

Committed r106147: <http://trac.webkit.org/changeset/106147>