Bug 77165 - JSC idl code generator generates bad code for [CachedAttribute] attributes
Summary: JSC idl code generator generates bad code for [CachedAttribute] attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 76035
  Show dependency treegraph
 
Reported: 2012-01-26 17:22 PST by Pablo Flouret
Modified: 2012-01-26 18:25 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.27 KB, patch)
2012-01-26 17:29 PST, Pablo Flouret
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Flouret 2012-01-26 17:22:51 PST
JSC idl code generator generates bad code for [CachedAttribute] attributes
Comment 1 Pablo Flouret 2012-01-26 17:29:03 PST
Created attachment 124223 [details]
Patch
Comment 2 Oliver Hunt 2012-01-26 17:44:50 PST
Comment on attachment 124223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000
> +        return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()";

what is the additional argument here for?
Comment 3 Pablo Flouret 2012-01-26 17:47:33 PST
(In reply to comment #2)
> (From update of attachment 124223 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124223&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3000
> > +        return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()";
> 
> what is the additional argument here for?

MessagePortArray*

MessageEvent (the only one declaring CachedAttributes so far) uses a custom getter, so i imagine that's why this has gone unnoticed.
Comment 4 WebKit Review Bot 2012-01-26 18:25:15 PST
Comment on attachment 124223 [details]
Patch

Clearing flags on attachment: 124223

Committed r106077: <http://trac.webkit.org/changeset/106077>
Comment 5 WebKit Review Bot 2012-01-26 18:25:19 PST
All reviewed patches have been landed.  Closing bug.