Bug 77163 - MacroAssemblerCodeRef.h uses OS(WIN) instead of OS(WINDOWS)
Summary: MacroAssemblerCodeRef.h uses OS(WIN) instead of OS(WINDOWS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks: 77162
  Show dependency tree / graph
 
Reported: 2012-01-26 16:57 PST by David Levin
Modified: 2012-01-30 12:58 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2012-01-26 16:57:15 PST 
Looks like it was introduced in http://trac.webkit.org/changeset/97189

The fix is trivial but I'm a little worried about just changing this (since I don't use this platform).
Comment 1 David Levin 2012-01-30 12:24:57 PST 
Note that OS(WIN) is never defined so the code in this if isn't used. My patch in 77162 will make code fail to build if it uses OS(WIN).

It is easy to make this mistake (and I did it as well) because there is a PLATFORM(WIN).
Comment 2 Gavin Barraclough 2012-01-30 12:58:43 PST 
Fixed in r106277