WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77161
Add API to get the parent frame in WKBundleFrameRef
https://bugs.webkit.org/show_bug.cgi?id=77161
Summary
Add API to get the parent frame in WKBundleFrameRef
Ada Chan
Reported
2012-01-26 16:28:07 PST
Add WKBundleFrameGetParentFrame(). This is needed for <
rdar://problem/10421393
>.
Attachments
Implementation + test
(18.24 KB, patch)
2012-01-26 16:45 PST
,
Ada Chan
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ada Chan
Comment 1
2012-01-26 16:45:28 PST
Created
attachment 124214
[details]
Implementation + test
Anders Carlsson
Comment 2
2012-01-26 16:52:13 PST
Comment on
attachment 124214
[details]
Implementation + test View in context:
https://bugs.webkit.org/attachment.cgi?id=124214&action=review
> Tools/TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:64 > + assert(childFrame); > + bool isParentFrameCheckSuccessful = childFrame ? WKBundleFrameGetParentFrame(childFrame.get()) == frame : false;
You have both an assert and a null check here, do you really need the assert?
Ada Chan
Comment 3
2012-01-27 11:42:44 PST
I removed the assert. Thanks for reviewing! Committed:
http://trac.webkit.org/changeset/106139
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug