Bug 77161 - Add API to get the parent frame in WKBundleFrameRef
Summary: Add API to get the parent frame in WKBundleFrameRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 16:28 PST by Ada Chan
Modified: 2012-01-27 11:42 PST (History)
1 user (show)

See Also:

Attachments
Implementation + test (18.24 KB, patch)
2012-01-26 16:45 PST, Ada Chan 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2012-01-26 16:28:07 PST 
Add WKBundleFrameGetParentFrame().

This is needed for <rdar://problem/10421393>.
Comment 1 Ada Chan 2012-01-26 16:45:28 PST 
Created attachment 124214 [details]
Implementation + test
Comment 2 Anders Carlsson 2012-01-26 16:52:13 PST 
Comment on attachment 124214 [details]
Implementation + test

View in context: https://bugs.webkit.org/attachment.cgi?id=124214&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:64
> +    assert(childFrame);
> +    bool isParentFrameCheckSuccessful = childFrame ? WKBundleFrameGetParentFrame(childFrame.get()) == frame : false;

You have both an assert and a null check here, do you really need the assert?
Comment 3 Ada Chan 2012-01-27 11:42:44 PST 
I removed the assert.  Thanks for reviewing!

Committed: http://trac.webkit.org/changeset/106139