WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77145
[JSC] Some JS_EXPORTDATA may not be necessary.
https://bugs.webkit.org/show_bug.cgi?id=77145
Summary
[JSC] Some JS_EXPORTDATA may not be necessary.
Hajime Morrita
Reported
2012-01-26 14:53:27 PST
This is derived from
Bug 72854
. Some JSC classes have s_info static class variables which are marked as JS_EXPORTDATA. But these may not be necessary. In this bug, we are going to investigate if we can remove them.
Attachments
Patch
(3.48 KB, patch)
2012-01-27 11:17 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hajime Morrita
Comment 1
2012-01-27 11:17:33 PST
Created
attachment 124339
[details]
Patch
Hajime Morrita
Comment 2
2012-01-27 11:20:46 PST
SInce I'm visiting a remote office I cannot check this on Windows for now. But I feel that we can see the obvious consequence on the bot... This patch is so small and it would be easy to rollout if the bot fails.
Hajime Morrita
Comment 3
2012-01-27 11:23:07 PST
Hi Darin and Kevin, Could you rubberstamp this small symbol adjustment stuff?
WebKit Review Bot
Comment 4
2012-01-27 14:41:08 PST
Comment on
attachment 124339
[details]
Patch Clearing flags on attachment: 124339 Committed
r106151
: <
http://trac.webkit.org/changeset/106151
>
WebKit Review Bot
Comment 5
2012-01-27 14:41:12 PST
All reviewed patches have been landed. Closing bug.
Hajime Morrita
Comment 6
2012-01-27 15:05:57 PST
Hmm Apple win bots are so red today that I cannot confirm that this patch works well... Please feel free to revert this if this has any possible problem/is suspicious in any level.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug