Bug 77144 - run-perf-test should include relative file paths in test names
Summary: run-perf-test should include relative file paths in test names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-01-26 14:51 PST by Ryosuke Niwa
Modified: 2012-01-26 19:50 PST (History)
7 users (show)

See Also:

Attachments
fixes the bug (3.42 KB, patch)
2012-01-26 15:29 PST, Ryosuke Niwa 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-01-26 14:51:20 PST 
Right now, run-perf-test only uses the filename as the test name but this won't scale when we add more perf tests.
Comment 1 Ryosuke Niwa 2012-01-26 15:29:18 PST 
Created attachment 124192 [details]
fixes the bug
Comment 2 Adam Barth 2012-01-26 15:39:39 PST 
Comment on attachment 124192 [details]
fixes the bug

ok.  How MacOS 9 of you!
Comment 3 Dirk Pranke 2012-01-26 15:48:20 PST 
Comment on attachment 124192 [details]
fixes the bug

Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'.
Comment 4 Ryosuke Niwa 2012-01-26 15:55:18 PST 
(In reply to comment #3)
> (From update of attachment 124192 [details])
> Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'.

We could but we don't have to match layout tests' convention either though. Is there any reason using '/' as the delimiter is better?
Comment 5 Dirk Pranke 2012-01-26 16:06:58 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 124192 [details] [details])
> > Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'.
> 
> We could but we don't have to match layout tests' convention either though. Is there any reason using '/' as the delimiter is better?

It seems to me that having a single convention used by the tools in a single code base would be better. That way I don't have to remember that it's run-webkit-tests fast/html but run-perf-tests fast:html .

I type this now realizing that what is in the JSON file is not necessarily what's on the command line, but it seems to me that being uniform is good, and if test names get displayed on a web page I would want them to display as "/" to match the other tools. If the chromium perf test store "foo:bar" but display "foo/bar", then ":" is fine by me.
Comment 6 Dirk Pranke 2012-01-26 16:07:52 PST 
(In reply to comment #5)
>  If the chromium perf test store "foo:bar" but display "foo/bar", then ":" is fine by me.

Well, "fine" might be a bit strong; I'd probably still grumble a little over it being different :).
Comment 7 Ryosuke Niwa 2012-01-26 16:28:53 PST 
I guess being able to copy & paste test name is a strong argument. Will change it to /.
Comment 8 Ryosuke Niwa 2012-01-26 19:50:01 PST 
http://trac.webkit.org/changeset/106062