Bug 77128 - Fix include path in gyp file for V8InternalSettings.h
Summary: Fix include path in gyp file for V8InternalSettings.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 12:08 PST by Scott Graham
Modified: 2012-01-26 14:27 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2012-01-26 14:04 PST, Scott Graham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2012-01-26 12:08:48 PST
See https://bugs.webkit.org/show_bug.cgi?id=76424. The correct path appears to be V8InternalSettings.h. Having the wrong path causes unnecessary rebuilds on Windows under VS2010.
Comment 1 Scott Graham 2012-01-26 14:04:27 PST
Created attachment 124177 [details]
Patch
Comment 2 Kent Tamura 2012-01-26 14:09:34 PST
Comment on attachment 124177 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-01-26 14:26:59 PST
Comment on attachment 124177 [details]
Patch

Clearing flags on attachment: 124177

Committed r106045: <http://trac.webkit.org/changeset/106045>
Comment 4 WebKit Review Bot 2012-01-26 14:27:03 PST
All reviewed patches have been landed.  Closing bug.