Bug 77117 - ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
Summary: ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andras Becsi
Depends on:
Reported: 2012-01-26 10:33 PST by Andras Becsi
Modified: 2012-01-26 10:47 PST (History)
3 users (show)

See Also:

proposed patch (1.31 KB, patch)
2012-01-26 10:35 PST, Andras Becsi
no flags Details | Formatted Diff | Diff
proposed patch with bug number (1.36 KB, patch)
2012-01-26 10:40 PST, Andras Becsi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2012-01-26 10:33:50 PST
The PageOverlay does only get uninstalled after the fade-out animation finishes, so do not assert on !m_overlay after the uninstallPageOverlay(m_overlay, /* fadeout */ true) call.
Comment 1 Andras Becsi 2012-01-26 10:35:15 PST
Created attachment 124140 [details]
proposed patch
Comment 2 WebKit Review Bot 2012-01-26 10:36:47 PST
Attachment 124140 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andras Becsi 2012-01-26 10:40:15 PST
Created attachment 124142 [details]
proposed patch with bug number
Comment 4 Andras Becsi 2012-01-26 10:47:05 PST
Comment on attachment 124142 [details]
proposed patch with bug number

Clearing flags on attachment: 124142

Committed r106012: <http://trac.webkit.org/changeset/106012>
Comment 5 Andras Becsi 2012-01-26 10:47:12 PST
All reviewed patches have been landed.  Closing bug.