Bug 77116 - Merge AllocationSpace into MarkedSpace
Summary: Merge AllocationSpace into MarkedSpace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 10:27 PST by Mark Hahnenberg
Modified: 2012-01-26 18:30 PST (History)
3 users (show)

See Also:


Attachments
Patch (30.29 KB, patch)
2012-01-26 10:37 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Fixing builds (33.02 KB, patch)
2012-01-26 10:54 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Fixing more build stuff (35.02 KB, patch)
2012-01-26 15:47 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Hopefully last build fix (35.08 KB, patch)
2012-01-26 16:08 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-01-26 10:27:17 PST
We have two separate classes that handle allocation in MarkedBlocks. It's unclear why we make the distinction between AllocationSpace and MarkedSpace. In preparation for future refactoring/enhancement of MarkedSpace allocation, we should merge AllocationSpace into MarkedSpace.
Comment 1 Mark Hahnenberg 2012-01-26 10:37:43 PST
Created attachment 124141 [details]
Patch
Comment 2 Mark Hahnenberg 2012-01-26 10:54:53 PST
Created attachment 124145 [details]
Fixing builds
Comment 3 Geoffrey Garen 2012-01-26 10:57:33 PST
Comment on attachment 124145 [details]
Fixing builds

rs=me
Comment 4 Early Warning System Bot 2012-01-26 11:17:25 PST
Comment on attachment 124145 [details]
Fixing builds

Attachment 124145 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11357002
Comment 5 Gyuyoung Kim 2012-01-26 11:25:25 PST
Comment on attachment 124145 [details]
Fixing builds

Attachment 124145 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11191414
Comment 6 Mark Hahnenberg 2012-01-26 15:47:17 PST
Created attachment 124198 [details]
Fixing more build stuff
Comment 7 Mark Hahnenberg 2012-01-26 16:08:54 PST
Created attachment 124204 [details]
Hopefully last build fix
Comment 8 Geoffrey Garen 2012-01-26 16:09:44 PST
Comment on attachment 124204 [details]
Hopefully last build fix

rs=me
Comment 9 WebKit Review Bot 2012-01-26 18:30:54 PST
Comment on attachment 124204 [details]
Hopefully last build fix

Clearing flags on attachment: 124204

Committed r106078: <http://trac.webkit.org/changeset/106078>
Comment 10 WebKit Review Bot 2012-01-26 18:30:59 PST
All reviewed patches have been landed.  Closing bug.