Bug 77113 - [WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
Summary: [WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 72854
  Show dependency tree / graph
 
Reported: 2012-01-26 10:15 PST by Hajime Morrita
Modified: 2012-01-27 12:53 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2012-01-27 10:40 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (3.56 KB, patch)
2012-01-27 11:14 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-01-26 10:15:24 PST 
As being mentioned at Bug 72854, there are some extra export annotation in WTFSTring.h which we can remove.
Comment 1 Hajime Morrita 2012-01-27 10:40:47 PST 
Created attachment 124334 [details]
Patch
Comment 2 Darin Adler 2012-01-27 10:43:51 PST 
Comment on attachment 124334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124334&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        * wtf/text/WTFString.h: Removed some redundant WTF_EXPORT_PRIVATE attributes.

To be clear, we are not removing these because they are “redundant”. We are removing them because we do not need to export these functions at this time.
Comment 3 Hajime Morrita 2012-01-27 11:09:48 PST 
Hi Darin, Thanks for your immediate review!

> > Source/JavaScriptCore/ChangeLog:8
> > +        * wtf/text/WTFString.h: Removed some redundant WTF_EXPORT_PRIVATE attributes.
> 
> To be clear, we are not removing these because they are “redundant”. We are removing them because we do not need to export these functions at this time.

That's right. I'll correct the explanation before land.
Comment 4 Hajime Morrita 2012-01-27 11:14:03 PST 
Created attachment 124338 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-27 12:53:43 PST 
Comment on attachment 124338 [details]
Patch for landing

Clearing flags on attachment: 124338

Committed r106143: <http://trac.webkit.org/changeset/106143>
Comment 6 WebKit Review Bot 2012-01-27 12:53:48 PST 
All reviewed patches have been landed.  Closing bug.