Bug 77109 - WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
Summary: WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 09:44 PST by Caio Marcelo de Oliveira Filho
Modified: 2012-01-26 09:59 PST (History)
0 users

See Also:


Attachments
Patch (2.73 KB, patch)
2012-01-26 09:48 PST, Caio Marcelo de Oliveira Filho
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2012-01-26 09:44:40 PST
Wrap static HashMap inside a function and use DEFINE_STATIC_LOCAL
Comment 1 Caio Marcelo de Oliveira Filho 2012-01-26 09:45:39 PST
This should fix build for Clang.
Comment 2 Caio Marcelo de Oliveira Filho 2012-01-26 09:48:31 PST
Created attachment 124131 [details]
Patch
Comment 3 Andreas Kling 2012-01-26 09:49:29 PST
Comment on attachment 124131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124131&action=review

> Source/WebKit2/Shared/WebPreferencesStore.cpp:188
> +    HashMap<String, bool>::const_iterator it = boolTestRunnerOverridesMap().find(key);

You could use BoolOverridesMap::const_iterator here for style points.
Comment 4 Caio Marcelo de Oliveira Filho 2012-01-26 09:59:30 PST
Committed r106008: <http://trac.webkit.org/changeset/106008>