Bug 77107 – [EFL] Introducing functions to set local storage db path and clear those dbs.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gustavo Lima Chaves]

[EFL] Introducing functions to set local storage db path and clear those dbs.

[Gustavo Lima Chaves]

Created attachment 124127 [details]
Patch

[Gustavo Lima Chaves]

Anton, Darin:

Now that you approved my StorageTracker WebCore changes, would you please kindly review the use of it at the EFL port?

Thank you, in advance.

[Gyuyoung Kim]

Comment on attachment 124127 [details]
Patch

Attachment 124127 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11386819

[Gustavo Lima Chaves]

Created attachment 125136 [details]
Patch

[Gustavo Lima Chaves]

(In reply to comment #4)
> Created an attachment (id=125136) [details]
> Patch

Sorry, 1st time using webkit-patch with new files, now done right.

[Gyuyoung Kim]

Comment on attachment 125136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125136&action=review

> Source/WebKit/efl/ChangeLog:7
> +

Missing description for this patch.

> Source/WebKit/efl/ewk/ewk_settings.h:101
> + *

I think this is unneeded line.

[Gustavo Lima Chaves]

Created attachment 125620 [details]
Patch

[Gustavo Lima Chaves]

(In reply to comment #6)
> 
> > Source/WebKit/efl/ChangeLog:7
> > +
> 
> Missing description for this patch.

OK, added more description of the work.

> 
> > Source/WebKit/efl/ewk/ewk_settings.h:101
> > + *
> 
> I think this is unneeded line.

Removed.

[Gustavo Lima Chaves]

(In reply to comment #8)

Does the patch look OK, Anton & Darin?

[Kenneth Rohde Christiansen]

Comment on attachment 125620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125620&action=review

Looks ok

> Source/WebKit/efl/ChangeLog:6
> +        This patch exposes the web local storage tracker database path setting cabability, introduced on bug 77006, to the EFL port of WebKit. Particularly, we have our own storage tracker client object, to initialize the storage tracker backend on ewk_init().

please split (max 80 - 100 chars)

[Gustavo Lima Chaves]

Created attachment 126311 [details]
Patch

[Gustavo Lima Chaves]

(In reply to comment #10)
> 
> please split (max 80 - 100 chars)
Done. Thank you very much, Kenneth :)

[Gustavo Lima Chaves]

Created attachment 126318 [details]
Patch

[Gustavo Lima Chaves]

Created attachment 126323 [details]
Patch

[Gustavo Lima Chaves]

Created attachment 126325 [details]
Patch

[WebKit Review Bot]

Comment on attachment 126325 [details]
Patch

Clearing flags on attachment: 126325

Committed r107260: <http://trac.webkit.org/changeset/107260>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.