Bug 77107 - [EFL] Introducing functions to set local storage db path and clear those dbs.
Summary: [EFL] Introducing functions to set local storage db path and clear those dbs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 77006
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-26 09:16 PST by Gustavo Lima Chaves
Modified: 2012-02-09 10:38 PST (History)
7 users (show)

See Also:


Attachments
Patch (6.43 KB, patch)
2012-01-26 09:16 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff
Patch (9.77 KB, patch)
2012-02-02 08:24 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff
Patch (10.00 KB, patch)
2012-02-06 05:13 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff
Patch (10.05 KB, patch)
2012-02-09 08:41 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff
Patch (10.05 KB, patch)
2012-02-09 09:37 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2012-02-09 10:10 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff
Patch (10.07 KB, patch)
2012-02-09 10:13 PST, Gustavo Lima Chaves
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Lima Chaves 2012-01-26 09:16:00 PST
[EFL] Introducing functions to set local storage db path and clear those dbs.
Comment 1 Gustavo Lima Chaves 2012-01-26 09:16:30 PST
Created attachment 124127 [details]
Patch
Comment 2 Gustavo Lima Chaves 2012-02-02 05:24:38 PST
Anton, Darin:

Now that you approved my StorageTracker WebCore changes, would you please kindly review the use of it at the EFL port?

Thank you, in advance.
Comment 3 Gyuyoung Kim 2012-02-02 06:02:12 PST
Comment on attachment 124127 [details]
Patch

Attachment 124127 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11386819
Comment 4 Gustavo Lima Chaves 2012-02-02 08:24:07 PST
Created attachment 125136 [details]
Patch
Comment 5 Gustavo Lima Chaves 2012-02-02 08:24:53 PST
(In reply to comment #4)
> Created an attachment (id=125136) [details]
> Patch

Sorry, 1st time using webkit-patch with new files, now done right.
Comment 6 Gyuyoung Kim 2012-02-04 20:22:23 PST
Comment on attachment 125136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125136&action=review

> Source/WebKit/efl/ChangeLog:7
> +

Missing description for this patch.

> Source/WebKit/efl/ewk/ewk_settings.h:101
> + *

I think this is unneeded line.
Comment 7 Gustavo Lima Chaves 2012-02-06 05:13:37 PST
Created attachment 125620 [details]
Patch
Comment 8 Gustavo Lima Chaves 2012-02-06 05:17:29 PST
(In reply to comment #6)
> 
> > Source/WebKit/efl/ChangeLog:7
> > +
> 
> Missing description for this patch.

OK, added more description of the work.

> 
> > Source/WebKit/efl/ewk/ewk_settings.h:101
> > + *
> 
> I think this is unneeded line.

Removed.
Comment 9 Gustavo Lima Chaves 2012-02-07 05:02:27 PST
(In reply to comment #8)

Does the patch look OK, Anton & Darin?
Comment 10 Kenneth Rohde Christiansen 2012-02-09 08:31:37 PST
Comment on attachment 125620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125620&action=review

Looks ok

> Source/WebKit/efl/ChangeLog:6
> +        This patch exposes the web local storage tracker database path setting cabability, introduced on bug 77006, to the EFL port of WebKit. Particularly, we have our own storage tracker client object, to initialize the storage tracker backend on ewk_init().

please split (max 80 - 100 chars)
Comment 11 Gustavo Lima Chaves 2012-02-09 08:41:15 PST
Created attachment 126311 [details]
Patch
Comment 12 Gustavo Lima Chaves 2012-02-09 08:42:09 PST
(In reply to comment #10)
> 
> please split (max 80 - 100 chars)
Done. Thank you very much, Kenneth :)
Comment 13 Gustavo Lima Chaves 2012-02-09 09:37:12 PST
Created attachment 126318 [details]
Patch
Comment 14 Gustavo Lima Chaves 2012-02-09 10:10:06 PST
Created attachment 126323 [details]
Patch
Comment 15 Gustavo Lima Chaves 2012-02-09 10:13:39 PST
Created attachment 126325 [details]
Patch
Comment 16 WebKit Review Bot 2012-02-09 10:38:22 PST
Comment on attachment 126325 [details]
Patch

Clearing flags on attachment: 126325

Committed r107260: <http://trac.webkit.org/changeset/107260>
Comment 17 WebKit Review Bot 2012-02-09 10:38:29 PST
All reviewed patches have been landed.  Closing bug.