Bug 77091 – Fix build when SUCCESS_STATS is enabled in DFG

• Status: NEW
• Component: JavaScriptCore

[Peter Varga]

SUCCESS_STATS requires SAMPLING_COUNTERS macro to be enabled for the build. Therefore we should warn the user when SAMPLING_COUNTERS is disabled.

[Peter Varga]

Created attachment 124101 [details]
proposed patch

Add check for SAMPLING_COUNTERS macro and avoid warnings on 64bit system.

[Peter Varga]

Created attachment 124102 [details]
proposed patch

Fix bug id in ChangeLog.

[Filip Pizlo]

Comment on attachment 124102 [details]
proposed patch

The Mac is unhappy!  The problem is this:

Undefined symbols for architecture x86_64:
  "__ZN3JSC23AbstractSamplingCounter4dumpEv", referenced from:
     -exported_symbol[s_list] command line option
  "__ZN3JSC23AbstractSamplingCounter30s_abstractSamplingCounterChainE", referenced from:
     -exported_symbol[s_list] command line option
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status

This is because you've changed things around in such a way that the mangled names changed.  You should remove those entries from JavaScriptCore.exp.  This may then cause link errors because some WebKit framework that uses JavaScriptCore (like WebCore, for instance) was relying on those symbols; once you get those new link errors, add the new symbols to JavaScriptCore.exp.

Flagging r-/cq- but only because this needs to be fixed before it's landed.  Otherwise your patch looks great!

[Peter Varga]

Created attachment 124510 [details]
proposed patch v2

Recover guards in SamplingCounter.(h|cpp) to make Mac happy.

[WebKit Review Bot]

Comment on attachment 124510 [details]
proposed patch v2

Rejecting attachment 124510 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
e/SamplingCounter.cpp
Hunk #1 FAILED at 37.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/runtime/SamplingCounter.cpp.rej
patching file Source/JavaScriptCore/runtime/SamplingCounter.h
Hunk #2 FAILED at 160.
1 out of 3 hunks FAILED -- saving rejects to file Source/JavaScriptCore/runtime/SamplingCounter.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gavin Barr..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11837097