Bug 77083 - Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
Summary: Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree impleme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks: 76443
  Show dependency treegraph
 
Reported: 2012-01-26 02:38 PST by Hans Wennborg
Modified: 2012-01-31 04:00 PST (History)
5 users (show)

See Also:


Attachments
Patch (50.06 KB, patch)
2012-01-26 02:50 PST, Hans Wennborg
fishd: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (50.08 KB, patch)
2012-01-29 23:57 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-01-26 02:38:00 PST
Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
Comment 1 Hans Wennborg 2012-01-26 02:50:14 PST
Created attachment 124086 [details]
Patch
Comment 2 Hans Wennborg 2012-01-26 02:53:39 PST
This moves the speech mock into DRT, as suggested in https://bugs.webkit.org/show_bug.cgi?id=76443#c22, allowing us to not expose it in the WebKit API, and removing the need for other implementations to carry this test code.

Please take a look.
Comment 3 WebKit Review Bot 2012-01-26 02:54:17 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 WebKit Review Bot 2012-01-26 04:22:56 PST
Comment on attachment 124086 [details]
Patch

Attachment 124086 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11163310
Comment 5 Darin Fisher (:fishd, Google) 2012-01-26 14:41:25 PST
Comment on attachment 124086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124086&action=review

> Source/WebKit/chromium/public/WebSpeechInputResult.h:49
> +    WEBKIT_EXPORT void set(const WebSpeechInputResult& other);

nit: we normally call a function with this signature "assign".  maybe both should be called assign, or maybe the first "set" should be broken out into separate setters for each property (which is how most "property bag" classes like this work).
Comment 6 Hans Wennborg 2012-01-29 23:57:12 PST
Created attachment 124500 [details]
Patch

Try to green the cr-linux EWS bot.
Comment 7 WebKit Review Bot 2012-01-30 00:49:05 PST
Comment on attachment 124500 [details]
Patch

Attachment 124500 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11369472

New failing tests:
css2.1/20110323/eof-002.htm
Comment 8 Hans Wennborg 2012-01-30 01:10:40 PST
(In reply to comment #5)
> (From update of attachment 124086 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124086&action=review
> 
> > Source/WebKit/chromium/public/WebSpeechInputResult.h:49
> > +    WEBKIT_EXPORT void set(const WebSpeechInputResult& other);
> 
> nit: we normally call a function with this signature "assign".

Done.

> maybe both should be called assign, or maybe the first "set" should be broken out into separate setters for each property (which is how most "property bag" classes like this work).

I will do this in a separate patch, as it will be a two-sided change.

(In reply to comment #7)
> (From update of attachment 124500 [details])
> Attachment 124500 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11369472
> 
> New failing tests:
> css2.1/20110323/eof-002.htm

I don't think that's me. At least it compiles now.
Comment 9 Hans Wennborg 2012-01-30 01:32:23 PST
Committed r106219: <http://trac.webkit.org/changeset/106219>
Comment 10 Hans Wennborg 2012-01-30 02:11:01 PST
Reverted r106219 for reason:

This broke Chromium's test_shell.

Committed r106223: <http://trac.webkit.org/changeset/106223>
Comment 11 Hans Wennborg 2012-01-31 04:00:20 PST
Committed r106353: <http://trac.webkit.org/changeset/106353>