Bug 77083 – Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hans Wennborg]

Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation

[Hans Wennborg]

Created attachment 124086 [details]
Patch

[Hans Wennborg]

This moves the speech mock into DRT, as suggested in https://bugs.webkit.org/show_bug.cgi?id=76443#c22, allowing us to not expose it in the WebKit API, and removing the need for other implementations to carry this test code.

Please take a look.

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[WebKit Review Bot]

Comment on attachment 124086 [details]
Patch

Attachment 124086 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11163310

[Darin Fisher (:fishd, Google)]

Comment on attachment 124086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124086&action=review

> Source/WebKit/chromium/public/WebSpeechInputResult.h:49
> +    WEBKIT_EXPORT void set(const WebSpeechInputResult& other);

nit: we normally call a function with this signature "assign".  maybe both should be called assign, or maybe the first "set" should be broken out into separate setters for each property (which is how most "property bag" classes like this work).

[Hans Wennborg]

Created attachment 124500 [details]
Patch

Try to green the cr-linux EWS bot.

[WebKit Review Bot]

Comment on attachment 124500 [details]
Patch

Attachment 124500 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11369472

New failing tests:
css2.1/20110323/eof-002.htm

[Hans Wennborg]

(In reply to comment #5)
> (From update of attachment 124086 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124086&action=review
> 
> > Source/WebKit/chromium/public/WebSpeechInputResult.h:49
> > +    WEBKIT_EXPORT void set(const WebSpeechInputResult& other);
> 
> nit: we normally call a function with this signature "assign".

Done.

> maybe both should be called assign, or maybe the first "set" should be broken out into separate setters for each property (which is how most "property bag" classes like this work).

I will do this in a separate patch, as it will be a two-sided change.

(In reply to comment #7)
> (From update of attachment 124500 [details])
> Attachment 124500 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11369472
> 
> New failing tests:
> css2.1/20110323/eof-002.htm

I don't think that's me. At least it compiles now.

[Hans Wennborg]

Committed r106219: <http://trac.webkit.org/changeset/106219>

[Hans Wennborg]

Reverted r106219 for reason:

This broke Chromium's test_shell.

Committed r106223: <http://trac.webkit.org/changeset/106223>

[Hans Wennborg]

Committed r106353: <http://trac.webkit.org/changeset/106353>