Bug 77079 – REGRESSION (r104746): iframes load PDFs as media documents

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

To reproduce: navigate to the URL. Click inside a PDF and choose File > Print.

Result: The iframes start out with a black background and movie playback controls, then change to PDF views. When printing, the print preview shows only the visible portion of the PDF, instead of the entire document.

[Radar WebKit Bug Importer]

<rdar://problem/10757933>

[Alexey Proskuryakov]

Adam, is this something you intend to look into?

[Adam Treat]

(In reply to comment #2)
> Adam, is this something you intend to look into?

Speaking to me?

[Adam Treat]

(In reply to comment #3)
> (In reply to comment #2)
> > Adam, is this something you intend to look into?
> 
> Speaking to me?

https://bugs.webkit.org/show_bug.cgi?id=76088

I don't see how, but can someone look and see if ^^ regressed it?

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Adam, is this something you intend to look into?
> > 
> > Speaking to me?
> 
> https://bugs.webkit.org/show_bug.cgi?id=76088
> 
> I don't see how, but can someone look and see if ^^ regressed it?

The title of this bug indicates the revision that caused it. If that's not clear, see bug 76088 comment #9.

[Adam Treat]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > Adam, is this something you intend to look into?
> > > 
> > > Speaking to me?
> > 
> > https://bugs.webkit.org/show_bug.cgi?id=76088
> > 
> > I don't see how, but can someone look and see if ^^ regressed it?
> 
> The title of this bug indicates the revision that caused it. If that's not clear, see bug 76088 comment #9.

Sorry Mitz, someone pointed this bug to me with no context, but it immediately struck a chord and I replied before reading the additional comment on 76088.  I will indeed have a look.

[Mark Rowe (bdash)]

Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch.

[Mark Rowe (bdash)]

Created attachment 126214 [details]
Patch to revert r104746.

[Adam Treat]

(In reply to comment #7)
> Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch.

I've looked and can't find the bug in the logic so revert is in order for now.  Sorry guys.  I'll continue to look.

[Adam Treat]

(In reply to comment #9)
> (In reply to comment #7)
> > Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch.
> 
> I've looked and can't find the bug in the logic so revert is in order for now.  Sorry guys.  I'll continue to look.

Probably be a lot easier to spot if I could build the Mac port to reproduce the regression.  I recently acquired a macbook pro so I'll work on that.

[Alexey Proskuryakov]

Comment on attachment 126214 [details]
Patch to revert r104746.

Thanks Adam!

[WebKit Review Bot]

Comment on attachment 126214 [details]
Patch to revert r104746.

Clearing flags on attachment: 126214

Committed r107256: <http://trac.webkit.org/changeset/107256>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.