Right now, runner.js defines a bunch of global functions in the global (window) scope. We should be defining a class instead.
Yeah, definitely. Go to town!
Created attachment 124677 [details] Wrap functions in PerfTestRunner
Comment on attachment 124677 [details] Wrap functions in PerfTestRunner My mindz! They are the blownz.
Comment on attachment 124677 [details] Wrap functions in PerfTestRunner Rejecting attachment 124677 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ching file PerformanceTests/Parser/tiny-innerHTML.html patching file PerformanceTests/Parser/url-parser.html patching file PerformanceTests/Parser/xml-parser.html patching file PerformanceTests/resources/runner.js Hunk #1 FAILED at 1. Hunk #2 succeeded at 99 (offset 11 lines). 1 out of 2 hunks FAILED -- saving rejects to file PerformanceTests/resources/runner.js.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 Full output: http://queues.webkit.org/results/11365944
Comment on attachment 124677 [details] Wrap functions in PerfTestRunner View in context: https://bugs.webkit.org/attachment.cgi?id=124677&action=review Some random nits as I was looking through the code... > PerformanceTests/resources/runner.js:2 > +var PerfTestRunner = { }; Nit: typical JS style is to not put a space between the curly braces here. > PerformanceTests/resources/runner.js:91 > + var start = new Date(); Nit: here and below I'd use Date.now(). Constructing a Date object is surprisingly expensive. Date.now() avoids the constructor and just gives the the current time.
Thanks for the review, Eric and thanks for the suggestions, Ojan. Landing it now.
Committed r106379: <http://trac.webkit.org/changeset/106379>