Bug 77073 - REGRESSION (r105555): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types
Summary: REGRESSION (r105555): Incorrect use of OS() macro breaks OwnPtr when used wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Blocker
Assignee: Andy Estes
URL:
Keywords: Regression
Depends on: 76738
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-26 00:10 PST by Andy Estes
Modified: 2012-01-26 00:17 PST (History)
0 users

See Also:

Attachments
Patch (1.68 KB, patch)
2012-01-26 00:14 PST, Andy Estes 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-01-26 00:10:44 PST 
r105555 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined. This should have been changed to OS(WINDOWS). This causes the preprocessor to strip out Win32 data type overrides for deleteOwnedPtr, causing allocations made by Win32 to be deleted by fastmalloc.
Comment 1 Andy Estes 2012-01-26 00:14:35 PST 
Created attachment 124069 [details]
Patch
Comment 2 Andy Estes 2012-01-26 00:17:59 PST 
Committed r105970: <http://trac.webkit.org/changeset/105970>