Bug 77071 - Revert code changes from r105800
Summary: Revert code changes from r105800
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 21:54 PST by Daniel Cheng
Modified: 2012-01-26 11:24 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2012-01-25 21:55 PST, Daniel Cheng 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2012-01-26 09:01 PST, Daniel Cheng 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2012-01-25 21:54:42 PST 
Revert code changes from r105800
Comment 1 Daniel Cheng 2012-01-25 21:55:37 PST 
Created attachment 124062 [details]
Patch
Comment 2 Jessie Berlin 2012-01-26 08:54:06 PST 
Comment on attachment 124062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review

So the test you added in http://trac.webkit.org/changeset/105800 would have passed without the code change?

Unofficial r=me (not a reviewer yet).

> Source/WebCore/ChangeLog:6
> +        The strings are already lowercased before they make their way to this function, so there's

Might be nice to say where they get lowercased.

> Source/WebCore/dom/Clipboard.cpp:215
> +                             

Looks like extra space snuck in here.
Comment 3 Daniel Cheng 2012-01-26 09:01:54 PST 
Created attachment 124124 [details]
Patch
Comment 4 Daniel Cheng 2012-01-26 09:03:09 PST 
Comment on attachment 124062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review

Yes, the test passes without this change. There was another change in the original CL as well and when I moved that change to another patch, I didn't check if the remaining code changes were still needed.

>> Source/WebCore/ChangeLog:6
>> +        The strings are already lowercased before they make their way to this function, so there's
> 
> Might be nice to say where they get lowercased.

Done.

>> Source/WebCore/dom/Clipboard.cpp:215
>> +                             
> 
> Looks like extra space snuck in here.

This was in the original change, but I went ahead and cleaned it up.
Comment 5 WebKit Review Bot 2012-01-26 11:23:59 PST 
Comment on attachment 124124 [details]
Patch

Clearing flags on attachment: 124124

Committed r106018: <http://trac.webkit.org/changeset/106018>
Comment 6 WebKit Review Bot 2012-01-26 11:24:04 PST 
All reviewed patches have been landed.  Closing bug.