Bug 77071 – Revert code changes from r105800

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Daniel Cheng]

Revert code changes from r105800

[Daniel Cheng]

Created attachment 124062 [details]
Patch

[Jessie Berlin]

Comment on attachment 124062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review

So the test you added in http://trac.webkit.org/changeset/105800 would have passed without the code change?

Unofficial r=me (not a reviewer yet).

> Source/WebCore/ChangeLog:6
> +        The strings are already lowercased before they make their way to this function, so there's

Might be nice to say where they get lowercased.

> Source/WebCore/dom/Clipboard.cpp:215
> +                             

Looks like extra space snuck in here.

[Daniel Cheng]

Created attachment 124124 [details]
Patch

[Daniel Cheng]

Comment on attachment 124062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124062&action=review

Yes, the test passes without this change. There was another change in the original CL as well and when I moved that change to another patch, I didn't check if the remaining code changes were still needed.

>> Source/WebCore/ChangeLog:6
>> +        The strings are already lowercased before they make their way to this function, so there's
> 
> Might be nice to say where they get lowercased.

Done.

>> Source/WebCore/dom/Clipboard.cpp:215
>> +                             
> 
> Looks like extra space snuck in here.

This was in the original change, but I went ahead and cleaned it up.

[WebKit Review Bot]

Comment on attachment 124124 [details]
Patch

Clearing flags on attachment: 124124

Committed r106018: <http://trac.webkit.org/changeset/106018>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.