Bug 77068 – [chromium] Add WebCore::FlingAnimator class for Android native-feel scrolling

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Tien-Ren Chen]

Add WebCore::FlingAnimator class for Android native-feel scrolling

[Tien-Ren Chen]

Created attachment 124057 [details]
Patch

[James Robinson]

Comment on attachment 124057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124057&action=review

I think that attempting to call straight into Java from WebKit is a bad approach (not to mention it won't compile on all of our configs).  Better would be to provide WebKit API for the embedder to control the fling animation curves and then call into that.

> Source/WebCore/platform/chromium/FlingAnimatorAndroid.cpp:29
> +#include "base/android/jni_android.h"

you can't #include files from base/ inside WebKit.  This won't even compile

> Source/WebCore/platform/chromium/FlingAnimatorAndroid.cpp:56
> +    JNIEnv* env = AttachCurrentThread();

calling into Java straight from WebKit?  Ick.  How do you plan to test this?

[Nat Duca]

Tian-ren, have you managed to sync up with wjmaclean? I believe he's got a crystalizing plan on how to cleanly abstract all this animation stuff.

[Tien-Ren Chen]

(In reply to comment #3)
> Tian-ren, have you managed to sync up with wjmaclean? I believe he's got a crystalizing plan on how to cleanly abstract all this animation stuff.

Not yet. I'm still working on the scrollbar changes. I'll follow up later on.

[Adam Barth]

*** This bug has been marked as a duplicate of bug 93514 ***