Parsing test_expecations.txt + Skipped lists takes too long
Created attachment 124035 [details]
Comment on attachment 124035 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=124035&action=review
> + for test in self._parser.parse_skipped_tests(tests_to_skip):
Nit: I would iterate directly over tests_to_skip here and change parse_skipped_tests to something like expectation_for_skipped_test(index, test).
Looks fine otherwise. I'm a bit surprised it's this slow, but there is so much python-level path handling in the code that I'm not that surprised. You should see how slow the MockFileSystem makes the unit tests :).
Committed r106038: <http://trac.webkit.org/changeset/106038>
Reopening to attach new patch.
Created attachment 124215 [details]
This was reverted in https://bugs.webkit.org/show_bug.cgi?id=77142. The bug was the we were missing a BUG modifier and were thus getting errors on each line and ignoring them. Fixed this and added a test to verify that we're actually ending up with the skipped tests expected to be skipped.
Comment on attachment 124215 [details]
Clearing flags on attachment: 124215
Committed r106293: <http://trac.webkit.org/changeset/106293>
All reviewed patches have been landed. Closing bug.