Bug 77059 - Parsing test_expecations.txt + Skipped lists takes too long
Summary: Parsing test_expecations.txt + Skipped lists takes too long
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
Depends on: 77142
  Show dependency treegraph
Reported: 2012-01-25 16:48 PST by Ojan Vafai
Modified: 2012-01-30 15:16 PST (History)
4 users (show)

See Also:

Patch (7.96 KB, patch)
2012-01-25 16:50 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (10.03 KB, patch)
2012-01-26 16:46 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-25 16:48:55 PST
Parsing test_expecations.txt + Skipped lists takes too long
Comment 1 Ojan Vafai 2012-01-25 16:50:50 PST
Created attachment 124035 [details]
Comment 2 Dirk Pranke 2012-01-25 16:59:25 PST
Comment on attachment 124035 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=124035&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:855
> +        for test in self._parser.parse_skipped_tests(tests_to_skip):

Nit: I would iterate directly over tests_to_skip here and change parse_skipped_tests to something like expectation_for_skipped_test(index, test). 

Looks fine otherwise. I'm a bit surprised it's this slow, but there is so much python-level path handling in the code that I'm not that surprised. You should see how slow the MockFileSystem makes the unit tests :).
Comment 3 Ojan Vafai 2012-01-26 13:46:55 PST
Committed r106038: <http://trac.webkit.org/changeset/106038>
Comment 4 Ojan Vafai 2012-01-26 16:46:55 PST
Reopening to attach new patch.
Comment 5 Ojan Vafai 2012-01-26 16:46:57 PST
Created attachment 124215 [details]
Comment 6 Ojan Vafai 2012-01-26 16:47:57 PST
This was reverted in https://bugs.webkit.org/show_bug.cgi?id=77142. The bug was the we were missing a BUG modifier and were thus getting errors on each line and ignoring them. Fixed this and added a test to verify that we're actually ending up with the skipped tests expected to be skipped.
Comment 7 WebKit Review Bot 2012-01-30 15:16:26 PST
Comment on attachment 124215 [details]

Clearing flags on attachment: 124215

Committed r106293: <http://trac.webkit.org/changeset/106293>
Comment 8 WebKit Review Bot 2012-01-30 15:16:31 PST
All reviewed patches have been landed.  Closing bug.