Bug 77051 – Layout/floats.html should be runnable by run-perf-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ryosuke Niwa]

run-perf-test should be able to run Layout/floats.html

We might want to consider splitting the test into multiple pieces and use runner.js.

[Alexandru Chiculita]

Created attachment 124294 [details]
Patch V1

[Ryosuke Niwa]

Comment on attachment 124294 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=124294&action=review

> PerformanceTests/Layout/resources/floats.js:7
> +    var nextRandomIndex = 0;

Maybe we should move a function I'm replacing Math.random with in https://bugs.webkit.org/attachment.cgi?id=124266&action=review to runner.js so you can use it here?

[Ryosuke Niwa]

I've committed my patch so you should be able to move move Math.random from
http://trac.webkit.org/browser/trunk/PerformanceTests/DOM/resources/dom-perf.js#L120
to
http://trac.webkit.org/browser/trunk/PerformanceTests/resources/runner.js

[Alexandru Chiculita]

Created attachment 124527 [details]
Patch V2

Moved Math.random to runner.js. Also, added a reset function to reset the seed after each run.

[Ryosuke Niwa]

Comment on attachment 124527 [details]
Patch V2

View in context: https://bugs.webkit.org/attachment.cgi?id=124527&action=review

> PerformanceTests/ChangeLog:9
> +        Some tests take longer to run and I've changed the number of iterations, so that each tests finishes under 1s per run.

Could you split this line into two before landing it? It's really long.

> PerformanceTests/ChangeLog:12
> +            Moved Math.random to runner.js.

We normally append the comment on the same line as the test name and : with one space. e.g.
* DOM/resources/dom-perf.js: Moved Math.random to runner.js.

> PerformanceTests/ChangeLog:36
> +            Moved the Math.random to runner.js to be used by all tests.
> +            Added resetRandomSeed to bring the randomizer back to initial seed.
> +            It is useful to get the same results at every run and minimize the
> +            differences between runs.

And when line wraps, we don't normally indent but instead align them to where ( is in (Math.random). (i.e. indented by exactly 8 spaces from the beginning).

[Ryosuke Niwa]

I think this patch is out of date after http://trac.webkit.org/changeset/106379.

[Alexandru Chiculita]

(In reply to comment #6)
> I think this patch is out of date after http://trac.webkit.org/changeset/106379.

Sorry, I've been out for a while. Will get back to this one ASAP.

[Alexandru Chiculita]

Created attachment 131966 [details]
Rebased patch

Rebased patch, but changed the code to put the methods in PerfTestRunner, so I'm sending it back to review.

[Alexandru Chiculita]

Created attachment 131967 [details]
Rebase #2

[Alexandru Chiculita]

Landed in r110801: http://trac.webkit.org/changeset/110801