run-perf-test should be able to run Layout/floats.html
We might want to consider splitting the test into multiple pieces and use runner.js.
Created attachment 124294 [details]
Comment on attachment 124294 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=124294&action=review
> + var nextRandomIndex = 0;
Maybe we should move a function I'm replacing Math.random with in https://bugs.webkit.org/attachment.cgi?id=124266&action=review to runner.js so you can use it here?
I've committed my patch so you should be able to move move Math.random from
Created attachment 124527 [details]
Moved Math.random to runner.js. Also, added a reset function to reset the seed after each run.
Comment on attachment 124527 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=124527&action=review
> + Some tests take longer to run and I've changed the number of iterations, so that each tests finishes under 1s per run.
Could you split this line into two before landing it? It's really long.
> + Moved Math.random to runner.js.
We normally append the comment on the same line as the test name and : with one space. e.g.
* DOM/resources/dom-perf.js: Moved Math.random to runner.js.
> + Moved the Math.random to runner.js to be used by all tests.
> + Added resetRandomSeed to bring the randomizer back to initial seed.
> + It is useful to get the same results at every run and minimize the
> + differences between runs.
And when line wraps, we don't normally indent but instead align them to where ( is in (Math.random). (i.e. indented by exactly 8 spaces from the beginning).
I think this patch is out of date after http://trac.webkit.org/changeset/106379.
(In reply to comment #6)
> I think this patch is out of date after http://trac.webkit.org/changeset/106379.
Sorry, I've been out for a while. Will get back to this one ASAP.
Created attachment 131966 [details]
Rebased patch, but changed the code to put the methods in PerfTestRunner, so I'm sending it back to review.
Created attachment 131967 [details]
Landed in r110801: http://trac.webkit.org/changeset/110801