Bug 77045 - Mac-ews logs are huge
Summary: Mac-ews logs are huge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 14:00 PST by Lucas Forschler
Modified: 2012-02-01 17:57 PST (History)
4 users (show)

See Also:

Attachments
Patch (15.42 KB, patch)
2012-02-01 16:31 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (15.53 KB, patch)
2012-02-01 16:48 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2012-01-25 14:00:42 PST 
The Mac ews Logs are gigantic in size... very verbose. 
some individual run logs are over 150MB.
the mac-ews.log was up to 2TB in size.  This should be rotated out.

Please make them less verbose.
Comment 1 Adam Barth 2012-02-01 16:31:44 PST 
Created attachment 125041 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-01 16:36:21 PST 
Comment on attachment 125041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125041&action=review

Looks OK.

> Tools/Scripts/webkitpy/tool/steps/runtests.py:81
> +                "--print=actual,config,expected,misc,slowest,unexpected,unexpected-results",

YOu should add a comment explaingin why this print command looks like this.
Comment 3 Adam Barth 2012-02-01 16:48:44 PST 
Created attachment 125043 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-02-01 17:57:13 PST 
Comment on attachment 125043 [details]
Patch for landing

Clearing flags on attachment: 125043

Committed r106518: <http://trac.webkit.org/changeset/106518>
Comment 5 WebKit Review Bot 2012-02-01 17:57:18 PST 
All reviewed patches have been landed.  Closing bug.