Bug 77022 - Remote web inspector reentrancy fixes
Summary: Remote web inspector reentrancy fixes
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-01-25 10:01 PST by Leo Franchi
Modified: 2012-02-08 07:11 PST (History)
4 users (show)

See Also:

Patch (2.38 KB, patch)
2012-01-25 10:02 PST, Leo Franchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Franchi 2012-01-25 10:01:51 PST
Remote web inspector reentrancy fixes
Comment 1 Leo Franchi 2012-01-25 10:02:26 PST
Created attachment 123965 [details]
Comment 2 Leo Franchi 2012-01-25 10:03:47 PST
The direct connection caused the tcp socket to no longer accept incoming events when waiting on a breakpoint.
Comment 3 Jocelyn Turcotte 2012-01-25 10:10:51 PST
It looks fine to me.
Kenneth, could you have a look too?
Comment 4 Joseph Pecoraro 2012-01-25 11:35:22 PST
Comment on attachment 123965 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=123965&action=review

> Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:364

A separate issue, but maybe the whole file/class should be in this enable.
The InspectorServer would be pretty useless without ENABLE(INSPECTOR) =)

r=me, this patch looks good to me.
Comment 5 Jesus Sanchez-Palencia 2012-02-08 05:47:59 PST
cq+ as requested by Leo Franchi on IRC.
Comment 6 WebKit Review Bot 2012-02-08 07:11:53 PST
Comment on attachment 123965 [details]

Clearing flags on attachment: 123965

Committed r107085: <http://trac.webkit.org/changeset/107085>
Comment 7 WebKit Review Bot 2012-02-08 07:11:57 PST
All reviewed patches have been landed.  Closing bug.