Bug 77003 - Make publicURLManagerMap thread safe
Summary: Make publicURLManagerMap thread safe
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 03:41 PST by Kaustubh Atrawalkar
Modified: 2012-02-07 00:55 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2012-01-25 03:45 PST, Kaustubh Atrawalkar 		levin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaustubh Atrawalkar 2012-01-25 03:41:28 PST 
With reference to bug - https://bugs.webkit.org/show_bug.cgi?id=74386 there are few missing fixes needed to be done. They are as follows -

1. Replace back removed "NoStaticTables" from DOMURL.idl. needed to allow this to be used with workers.
2. The methods publicURLManagerMap and publicURLManager aren't threadsafe so they has potential race conditions since it can be called on Web Worker threads as well as the main thread. Make them thread-safe.
Comment 1 Kaustubh Atrawalkar 2012-01-25 03:45:10 PST 
Created attachment 123915 [details]
Patch

Added AtomicallyInitializedStatic to make publicURLmanager thread safe.
Replaced NoStaticTables.
Comment 2 David Levin 2012-01-25 10:07:54 PST 
Comment on attachment 123915 [details]
Patch

Per https://bugs.webkit.org/show_bug.cgi?id=74386#c34
Comment 3 Kaustubh Atrawalkar 2012-02-07 00:55:57 PST 
This issue is collected in https://bugs.webkit.org/show_bug.cgi?id=74386 by rolling out the patch and fixing the patch itself.